Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Validation/Scoring add unit tests #1881

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

jeremywiebe
Copy link
Collaborator

@jeremywiebe jeremywiebe commented Nov 19, 2024

Summary:

Adding two unit tests to ensure that our validation is called and handled properly in the scoring function.

Issue: LEMS-2598

Test plan:

yarn test
yarn typecheck

@jeremywiebe jeremywiebe self-assigned this Nov 19, 2024
@jeremywiebe jeremywiebe marked this pull request as ready for review November 19, 2024 00:51
@khan-actions-bot khan-actions-bot requested a review from a team November 19, 2024 00:51
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Nov 19, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to packages/perseus/src/widgets/table/score-table.test.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Nov 19, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (21e4768) and published it to npm. You
can install it using the tag PR1881.

Example:

yarn add @khanacademy/perseus@PR1881

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1881

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Size Change: 0 B

Total Size: 1.29 MB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.9 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.8 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 697 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 423 kB
packages/perseus/dist/es/strings.js 3.57 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@jeremywiebe jeremywiebe changed the title Table: Scoring and Validation - use conventions Table: Validation/Scoring add unit tests Nov 19, 2024
@handeyeco
Copy link
Contributor

I'm confused between this and #1883

@jeremywiebe
Copy link
Collaborator Author

I'm confused between this and #1883

I made it confusing. 😞 There was a commit from 1883 mixed into this PR. I've removed it so this PR is now strictly some unit tests for the table widget.

@jeremywiebe jeremywiebe merged commit f5ef6dd into main Nov 20, 2024
9 checks passed
@jeremywiebe jeremywiebe deleted the jer/validation-conventions-table branch November 20, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants