-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table: Validation/Scoring add unit tests #1881
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (21e4768) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1881 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1881 |
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
I'm confused between this and #1883 |
This reverts commit 5467d26.
I made it confusing. 😞 There was a commit from 1883 mixed into this PR. I've removed it so this PR is now strictly some unit tests for the |
Summary:
Adding two unit tests to ensure that our validation is called and handled properly in the scoring function.
Issue: LEMS-2598
Test plan:
yarn test
yarn typecheck