Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number Line: Extract validation out of scoring #1901

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Number Line: Extract validation out of scoring #1901

wants to merge 5 commits into from
+183 −113

Commits on Nov 21, 2024

  1. Split validate logic to own function 

    Rename state to userInput
Rename rubric to scoringData
Rename rubric type
    @Myranae
    Myranae committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    2d30658 View commit details
    Browse the repository at this point in the history

  2. Split out validation tests 

    Add check for null return on validation pass
Remove test helpers
Rename rubric to scoringData
    @Myranae
    Myranae committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    09ae628 View commit details
    Browse the repository at this point in the history

  3. Rename rubric type to scoringData and add validation type 

    Update scoringData type to union with ValidationData
    @Myranae
    Myranae committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    dfad0ec View commit details
    Browse the repository at this point in the history

  4. Add changeset

    @Myranae
    Myranae committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d0083a4 View commit details
    Browse the repository at this point in the history

  5. Remove unneeded import

    @Myranae
    Myranae committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    47f4c3f View commit details
    Browse the repository at this point in the history