Radio: Extract validation out of scoring #1902
Open
+82
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (b8332f9) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1902If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1902 |
|
Size Change: +157 B (+0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
Myranae
commented
Nov 21, 2024
Comment on lines
-17
to
-23
| if (numSelected === 0) { | ||
| return { | ||
| type: "invalid", | ||
| message: null, | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
The remaining validation checks rely on data in the scoringData object, so I don't think we can move those to the validation function. If it's possible, would love to know so we can move all that over!
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
jeremywiebe
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To complete server-side scoring, we are separating out validation logic from scoring logic. This PR separates validation logic that does not depend on answer information and also separates associated tests for the radio widget.
Issue: LEMS-2594
Test plan: