Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Storybook v8.x #1904

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Upgrade Storybook v8.x #1904

wants to merge 6 commits into from

Conversation

mark-fitzgerald
Copy link
Contributor

@mark-fitzgerald mark-fitzgerald commented Nov 21, 2024

Summary:

Nothing is broken. Everything is happy.

Test plan:

yarn start is happy
yarn build-storybook; python3 -m http.server -d storybook-static; -> open http://localhost:8000 in a browser
yarn build-storybook --stats-json works and generates /storybook-static/preview-stats.json
yarn dev is happy

Adjust Storybook files accordingly.
@mark-fitzgerald mark-fitzgerald self-assigned this Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Size Change: -99 B (-0.01%)

Total Size: 1.29 MB

Filename Size Change
packages/kas/dist/es/index.js 39 kB +5 B (+0.01%)
packages/math-input/dist/es/index.js 77.9 kB -3 B (0%)
packages/perseus-editor/dist/es/index.js 698 kB -60 B (-0.01%)
packages/perseus-linter/dist/es/index.js 22.2 kB -2 B (-0.01%)
packages/perseus/dist/es/index.js 425 kB -38 B (-0.01%)
packages/simple-markdown/dist/es/index.js 12.5 kB -1 B (-0.01%)
ℹ️ View Unchanged
Filename Size
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus/dist/es/strings.js 3.57 kB
packages/pure-markdown/dist/es/index.js 3.66 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Nov 22, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (015acb1) and published it to npm. You
can install it using the tag PR1904.

Example:

yarn add @khanacademy/perseus@PR1904

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant