Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting all Server Side Scoring and Input Number conversion Project logic #1905

Merged
merged 9 commits into from
Nov 22, 2024

Conversation

SonicScrewdriver
Copy link
Contributor

@SonicScrewdriver SonicScrewdriver commented Nov 22, 2024

Summary:

In order to unblock Perseus, we are reverting the following commits:

Test plan:

  • manual testing

@SonicScrewdriver SonicScrewdriver self-assigned this Nov 22, 2024
@khan-actions-bot khan-actions-bot requested a review from a team November 22, 2024 19:12
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Nov 22, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/stupid-pillows-hug.md, dev/flipbook.tsx, testing/renderer-with-debug-ui.tsx, packages/perseus/src/index.ts, packages/perseus/src/perseus-types.ts, packages/perseus/src/renderer-util.test.ts, packages/perseus/src/renderer-util.ts, packages/perseus/src/renderer.tsx, packages/perseus/src/server-item-renderer.tsx, packages/perseus/src/types.ts, packages/perseus/src/widgets.ts, packages/perseus-editor/src/article-editor.tsx, packages/perseus-editor/src/editor-page.tsx, packages/perseus-editor/src/editor.tsx, packages/perseus/src/__stories__/server-item-renderer.stories.tsx, packages/perseus/src/__testdata__/extract-perseus-data.testdata.ts, packages/perseus/src/__testdata__/renderer.testdata.ts, packages/perseus/src/__testdata__/server-item-renderer.testdata.ts, packages/perseus/src/__tests__/extract-perseus-data.test.ts, packages/perseus/src/__tests__/renderability.test.ts, packages/perseus/src/__tests__/renderer-api.test.tsx, packages/perseus/src/__tests__/renderer.test.tsx, packages/perseus/src/__tests__/server-item-renderer.test.tsx, packages/perseus/src/styles/styles.less, packages/perseus-editor/src/__stories__/article-editor.stories.tsx, packages/perseus-editor/src/__stories__/editor-page.stories.tsx, packages/perseus-editor/src/__tests__/traversal.test.ts, packages/perseus/src/__tests__/__snapshots__/server-item-renderer.test.tsx.snap, packages/perseus/src/__tests__/test-items/input-number-1-item.ts, packages/perseus/src/__tests__/test-items/input-number-2-item.ts, packages/perseus/src/components/__tests__/sorter.test.tsx, packages/perseus/src/multi-items/__testdata__/multi-renderer.testdata.ts, packages/perseus/src/multi-items/__tests__/multi-renderer.test.tsx, packages/perseus/src/widget-ai-utils/input-number/input-number-ai-utils.test.ts, packages/perseus/src/widgets/categorizer/categorizer.test.ts, packages/perseus/src/widgets/definition/definition.test.ts, packages/perseus/src/widgets/expression/expression.test.tsx, packages/perseus/src/widgets/group/group.test.tsx, packages/perseus/src/widgets/group/group.tsx, packages/perseus/src/widgets/input-number/input-number.test.ts, packages/perseus/src/widgets/input-number/input-number.testdata.ts, packages/perseus/src/widgets/matcher/matcher.test.tsx, packages/perseus/src/widgets/matrix/matrix.test.ts, packages/perseus/src/widgets/numeric-input/numeric-input.tsx, packages/perseus/src/multi-items/__tests__/__snapshots__/multi-renderer.test.tsx.snap, packages/perseus/src/widgets/deprecated-standin/__tests__/deprecated-standin.test.ts, packages/perseus/src/widgets/graded-group-set/__snapshots__/graded-group-set-jipt.test.ts.snap, packages/perseus/src/widgets/graded-group-set/__snapshots__/graded-group-set.test.ts.snap, packages/perseus/src/widgets/group/__snapshots__/group.test.tsx.snap, packages/perseus/src/widgets/input-number/__snapshots__/input-number.test.ts.snap, packages/perseus/src/widgets/numeric-input/__snapshots__/numeric-input.test.ts.snap, packages/perseus/src/widgets/passage/__tests__/passage.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@SonicScrewdriver SonicScrewdriver changed the title Fixing messiness with AI Utils Test Files, and renderer tests Reverting all Server Side Scoring and Input Number conversion Project logic Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (194cc53) and published it to npm. You
can install it using the tag PR1905.

Example:

yarn add @khanacademy/perseus@PR1905

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1905

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Size Change: -4.07 kB (-0.32%)

Total Size: 1.29 MB

Filename Size Change
packages/perseus-editor/dist/es/index.js 697 kB -516 B (-0.07%)
packages/perseus/dist/es/index.js 421 kB -3.55 kB (-0.84%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.9 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.57 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

Copy link
Member

@catandthemachines catandthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the storybook pages through chromatic and it looks good to me.

@SonicScrewdriver SonicScrewdriver merged commit 9c225f9 into main Nov 22, 2024
16 of 21 checks passed
@SonicScrewdriver SonicScrewdriver deleted the revert-perseus-to-unblock branch November 22, 2024 22:40
SonicScrewdriver added a commit that referenced this pull request Nov 22, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @khanacademy/[email protected]

### Major Changes

- [#1905](#1905)
[`9c225f936`](9c225f9)
Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - We're
reverting work done for the Server Side Scoring and Input Number
Conversion projects.

### Minor Changes

- [#1883](#1883)
[`adad642ab`](adad642)
Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Introduces a
validation function for the matrix widget (extracted from matrix scoring
function).


- [#1878](#1878)
[`a27f23bb4`](a27f23b)
Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Add expression
validator function

### Patch Changes

- [#1890](#1890)
[`0afb1a4f7`](0afb1a4)
Thanks [@nishasy](https://github.com/nishasy)! - [Locked Labels + Aria]
Create math only parser to help parse TeX how we want


- [#1889](#1889)
[`55a532175`](55a5321)
Thanks [@benchristel](https://github.com/benchristel)! - Internal:
enable strict typechecking of function parameters


- [#1852](#1852)
[`4b8836b84`](4b8836b)
Thanks [@catandthemachines](https://github.com/catandthemachines)! -
Adding open and closing behavior to unlimited polygon graph type.

- Updated dependencies
\[[`55a532175`](55a5321)]:
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Major Changes

- [#1905](#1905)
[`9c225f936`](9c225f9)
Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - We're
reverting work done for the Server Side Scoring and Input Number
Conversion projects.

### Patch Changes

- [#1889](#1889)
[`55a532175`](55a5321)
Thanks [@benchristel](https://github.com/benchristel)! - Internal:
enable strict typechecking of function parameters

- Updated dependencies
\[[`adad642ab`](adad642),
[`0afb1a4f7`](0afb1a4),
[`55a532175`](55a5321),
[`9c225f936`](9c225f9),
[`4b8836b84`](4b8836b),
[`a27f23bb4`](a27f23b)]:
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Patch Changes

- [#1889](#1889)
[`55a532175`](55a5321)
Thanks [@benchristel](https://github.com/benchristel)! - Internal:
enable strict typechecking of function parameters

## @khanacademy/[email protected]

### Patch Changes

- [#1889](#1889)
[`55a532175`](55a5321)
Thanks [@benchristel](https://github.com/benchristel)! - Internal:
enable strict typechecking of function parameters

## @khanacademy/[email protected]

### Patch Changes

- Updated dependencies
\[[`55a532175`](55a5321)]:
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Patch Changes

- [#1889](#1889)
[`55a532175`](55a5321)
Thanks [@benchristel](https://github.com/benchristel)! - Internal:
enable strict typechecking of function parameters

## @khanacademy/[email protected]

### Major Changes

- [#1905](#1905)
[`9c225f936`](9c225f9)
Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - We're
reverting work done for the Server Side Scoring and Input Number
Conversion projects.

### Patch Changes

- Updated dependencies
\[[`55a532175`](55a5321)]:
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
    -   @khanacademy/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants