Skip to content

Commit

Permalink
remove icon styling changes to revert to original styling. there were…
Browse files Browse the repository at this point in the history
… some issues with text alignment
  • Loading branch information
beaesguerra committed Nov 18, 2024
1 parent ce89fc7 commit 5f9f586
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion .changeset/breezy-bears-teach.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@
# SearchField

- Adds `error`, `instantValidation`, `validate`, and `onValidate` props to be consistent with form components.
- Refine icon styling and use semantic color tokens
- Hide the clear button if the SearchField is disabled
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ import * as React from "react";
import {StyleSheet} from "aphrodite";

import xIcon from "@phosphor-icons/core/regular/x.svg";
import magnifyingGlassIcon from "@phosphor-icons/core/bold/magnifying-glass-bold.svg";
import magnifyingGlassIcon from "@phosphor-icons/core/regular/magnifying-glass.svg";

import {styles as typographyStyles} from "@khanacademy/wonder-blocks-typography";
import {View, IDProvider} from "@khanacademy/wonder-blocks-core";
import IconButton from "@khanacademy/wonder-blocks-icon-button";
import {TextField} from "@khanacademy/wonder-blocks-form";
import {PhosphorIcon} from "@khanacademy/wonder-blocks-icon";
import {semanticColor, spacing} from "@khanacademy/wonder-blocks-tokens";
import {color, spacing} from "@khanacademy/wonder-blocks-tokens";
import type {StyleType, AriaProps} from "@khanacademy/wonder-blocks-core";

import {defaultLabels} from "../util/constants";
Expand Down Expand Up @@ -195,8 +195,8 @@ const SearchField: React.ForwardRefExoticComponent<
<View onClick={onClick} style={[styles.inputContainer, style]}>
<PhosphorIcon
icon={magnifyingGlassIcon}
size="small"
color={semanticColor.icon.primary}
size="medium"
color={color.offBlack64}
style={styles.searchIcon}
aria-hidden="true"
/>
Expand Down

0 comments on commit 5f9f586

Please sign in to comment.