Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchField: Add validation props and refine states #2363

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

SearchField: Add validation props and refine states #2363

wants to merge 19 commits into from
+551 −28

Commits on Nov 13, 2024

  1. SearchField: Add error prop and update icon styling

    @beaesguerra
    beaesguerra committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    db91d02 View commit details
    Browse the repository at this point in the history

  2. SearchField: Add variants story and address styling issues by relying… 

    … on TextField styles
    @beaesguerra
    beaesguerra committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e6a0a31 View commit details
    Browse the repository at this point in the history

  3. SearchField: Don't render clear icon button if the field is disabled

    @beaesguerra
    beaesguerra committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5be918d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Add instantValidation, validate, onValidate props to SearchField

    @beaesguerra
    beaesguerra committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9a012f2 View commit details
    Browse the repository at this point in the history

  2. add tests

    @beaesguerra
    beaesguerra committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9981f8e View commit details
    Browse the repository at this point in the history

  3. fix styling so hover + focus state doesn't remove the focus outline

    @beaesguerra
    beaesguerra committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    96337dc View commit details
    Browse the repository at this point in the history

  4. Disable chromatic snapshots

    @beaesguerra
    beaesguerra committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    133be86 View commit details
    Browse the repository at this point in the history

  5. update docs

    @beaesguerra
    beaesguerra committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    173aaf5 View commit details
    Browse the repository at this point in the history

  6. add changeset

    @beaesguerra
    beaesguerra committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    519c6a7 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. add test for hiding clear button when field is disabled

    @beaesguerra
    beaesguerra committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    f7ca531 View commit details
    Browse the repository at this point in the history

  2. update changeset

    @beaesguerra
    beaesguerra committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    38d94fc View commit details
    Browse the repository at this point in the history

  3. add test

    @beaesguerra
    beaesguerra committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ce89fc7 View commit details
    Browse the repository at this point in the history

  4. remove icon styling changes to revert to original styling. there were… 

    … some issues with text alignment
    @beaesguerra
    beaesguerra committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5f9f586 View commit details
    Browse the repository at this point in the history

  5. Fix up magnifying icon styling

    @beaesguerra
    beaesguerra committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7898c96 View commit details
    Browse the repository at this point in the history

  6. Update validation story

    @beaesguerra
    beaesguerra committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e0569b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. address PR comments: clean up styling

    @beaesguerra
    beaesguerra committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9151f56 View commit details
    Browse the repository at this point in the history

  2. update clear icon button: bold icon, smaller, spacing

    @beaesguerra
    beaesguerra committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d2e3190 View commit details
    Browse the repository at this point in the history

  3. fix lint

    @beaesguerra
    beaesguerra committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b286e3a View commit details
    Browse the repository at this point in the history

  4. Use small size for dismiss button so it has a bigger hit area. Use th… 

    …e regular icon again so the bold icon isn't too prominent
    @beaesguerra
    beaesguerra committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d2a4cd5 View commit details
    Browse the repository at this point in the history