Simplify grammar for init-declarators #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a single grammar term for declarators (identifier followed by an optional array-specifier) and init-declarators (declarators with optional initialisation). This simplifies a few rules and makes things a bit more consistent.
|
@dj2 These 3 changes are the simplifications that I ended up implementing in my compiler. There are definitely more things that would make the grammar simpler, and interestingly our changes don't really intersect all the much, so we can probably do both. If there's interest in maintaining the grammar then there are further things that I'd like to fix. |
dj2
approved these changes
Sep 11, 2024
pdaniell-nv
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single grammar term for declarators (identifier followed by an optional array-specifier) and init-declarators (declarators with optional initialisation). This simplifies a few rules and makes things a bit more consistent.