-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTXwriterScParams support #779
KTXwriterScParams support #779
Conversation
Please rebase to get the MinGW fix. Looks good but the repetition of so many string values is unfortunate. Is there a way to reduce the repetition? If not, please define a const string object for each value and refer to that at each place where needed. |
Yeah, I tried to minimize that, in fact eliminated one of them. We could use some consts, sure. |
2475f54
to
ee528c0
Compare
Please do it. Note that my e-mail service is currently broken. I can neither send nor receive messages from my regular addresses. Therefore my responses may be somewhat delayed. |
I've rebased and added string constants for all the places where it made sense. This should be fine once CI passes.
Is there any channel through which we can contact you privately in the meantime? |
I've just sent you a message from it. |
fef1a1d
to
d1272d3
Compare
Removed "astc-mode" option, as requested. Instead, default to LDR mode for UNORM/SRGB. |
d1272d3
to
ac622ce
Compare
ac622ce
to
8147cb2
Compare
Updated CTS git submodule hash. Ready for merge. |
Fixes #758.
Depends on the CTS PR KhronosGroup/KTX-Software-CTS#5.
@MarkCallow FYI (please make sure you merge the CTS PR first with rebasing policy).