-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move self-hosted dependencies to external
folder
#909
Conversation
96835f3
to
a21ac63
Compare
a21ac63
to
3f40369
Compare
@MarkCallow, this is the first step we already discussed in PR #889, moving the external dependencies to a dedicated external repo. Please review it so that we can merge it ASAP. |
Not sure why you need that fix for gl3loadtests. It's been building on Windows for a very long time. You still need to fix You need to fix paths in the Web-related sources, I'll start a proper review later this week. I'm still working on PR #874 (coding not reviewing). |
Throwing bad_vulkan_alloc triggered MSVC warning C5272
reuse is still failing related to I've reviewed the basisu-related changes. They look good. More tomorrow. |
@MarkCallow I fixed the Reuse issues. CI is now failing on the Emscripten bindings, but I believe it is unrelated to the changes here and is a result of the image having changed in the last few hours. The compilation error is not include or link related but a DTOR being explicitly marked deleted. |
Aargh! Why do people keep making breaking changes? I am just finishing up major changes to the JS wrapper. I've been using Emscripten 3.1.59. This failing build is using 3.1.60. It is appropriate that the subject copy constructor is marked deleted. I'll probably have to consult the Emscripten people to figure out a fix. I might have to get the major wrapper changes merged to main before you can get the fix. I'll look into it tomorrow. It is late evening here now. |
The changes to Emscripten are apparently intentional. However the fix they suggested makes zero difference. Finding a fix will take more time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good. Hopefully I can find a fix for the Emscripten build quickly.
Here is a patch for the Emscripten 3.1.60 issue. Please add it to this PR. |
@MarkCallow @aqnuep All lights are green. |
@MathiasMagnus thank you for this well organized piece of work. |
This PR splits the work prototyped in #889 to have only the file reorg in preparation for Clang-tidy and Clang-format.
Notes for the reviewers
glloadtests
)