unify the CL_INVALID_COMMAND_QUEUE behavior for semaphore signals and…

… waits (#1256)
KhronosGroup · Sep 12, 2024 · 443d25b · 443d25b
1 parent fe6b158
commit 443d25b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/api/cl_khr_semaphore.asciidoc b/api/cl_khr_semaphore.asciidoc
@@ -255,3 +255,6 @@ while (true) {
      {CL_SEMAPHORE_DEVICE_HANDLE_LIST_KHR} (provisional).
   * Revision 1.0.0, 2024-03-15
   ** First non-provisional version.
+  * Revision 1.0.1, 2024-09-08
+  ** Unified {CL_INVALID_COMMAND_QUEUE} error behavior for
+     {clEnqueueSignalSemaphoresKHR} and {clEnqueueWaitSemaphoresKHR}.
diff --git a/api/opencl_runtime_layer.asciidoc b/api/opencl_runtime_layer.asciidoc
@@ -13285,7 +13285,9 @@ Otherwise, it returns one of the following errors:
   ** if _command_queue_ is not a valid command-queue, or
   ** if the device associated with _command_queue_ is not same as one of the
      devices specified by {CL_SEMAPHORE_DEVICE_HANDLE_LIST_KHR} at the time
-     of creating one or more of _sema_objects_.
+     of creating one or more of _sema_objects_, or
+  ** if one or more of _sema_objects_ belong to a context that does not
+     contain a device associated with _command_queue_.
   * {CL_INVALID_VALUE} if _num_sema_objects_ is 0.
   * {CL_INVALID_SEMAPHORE_KHR} if any of the semaphore objects specified by
     _sema_objects_ is not valid.
@@ -13398,11 +13400,11 @@ Otherwise, it returns one of the following errors:
     _sema_objects_ requires a semaphore payload and _sema_payload_list_ is
     `NULL`.
   * {CL_INVALID_EVENT_WAIT_LIST}
-      ** if _event_wait_list_ is `NULL` and _num_events_in_wait_list_ is not
-         0, or
-      ** if _event_wait_list_ is not `NULL` and _num_events_in_wait_list_ is
-         0, or
-      ** if event objects in _event_wait_list_ are not valid events.
+  ** if _event_wait_list_ is `NULL` and _num_events_in_wait_list_ is not 0,
+     or
+  ** if _event_wait_list_ is not `NULL` and _num_events_in_wait_list_ is 0,
+     or
+  ** if event objects in _event_wait_list_ are not valid events.
   * {CL_EXEC_STATUS_ERROR_FOR_EVENTS_IN_WAIT_LIST} if the execution status
     of any of the events in _event_wait_list_ is a negative integer value.
   * {CL_OUT_OF_RESOURCES} if there is a failure to allocate resources
@@ -13411,7 +13413,6 @@ Otherwise, it returns one of the following errors:
     required by the OpenCL implementation on the host.
 --
 
-
 === Retaining and Releasing Semaphores
 
 [open,refpage='clReleaseSemaphoreKHR',desc='Release a semaphore object',type='protos']