Skip to content

Commit

Permalink
Fixup cl_khr_command_buffer after spec unification
Browse files Browse the repository at this point in the history
After PR #950 merged the cl_khr_command_buffer spec needs
updated in a couple of places:

* Error around _num_queues_ to `clCreateCommandBufferKHR` should
  be in terms of `cl_khr_command_buffer_multi_device`.
* "New Structure" heading can be deleted as these are listed under
  "New Types"
* Typos in rendering of some types
  • Loading branch information
EwanC committed Mar 25, 2024
1 parent 774425a commit 92cb7d8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
11 changes: 3 additions & 8 deletions api/cl_khr_command_buffer.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,6 @@ extensions to relax usage of the following API features:
** {clCommandSVMMemcpyKHR}
** {clCommandSVMMemFillKHR}

=== New Structures

* {cl_command_buffer_khr}
* {cl_mutable_command_khr}

=== New Types

* {cl_device_command_buffer_capabilities_khr_TYPE}
Expand All @@ -220,16 +215,16 @@ extensions to relax usage of the following API features:
* {cl_device_info_TYPE}
** {CL_DEVICE_COMMAND_BUFFER_CAPABILITIES_KHR}
** {CL_DEVICE_COMMAND_BUFFER_REQUIRED_QUEUE_PROPERTIES_KHR}
* {cl_device_command_buffer_capabilities_khr - bitfield_TYPE}
* {cl_device_command_buffer_capabilities_khr_TYPE}
** {CL_COMMAND_BUFFER_CAPABILITY_KERNEL_PRINTF_KHR}
** {CL_COMMAND_BUFFER_CAPABILITY_DEVICE_SIDE_ENQUEUE_KHR}
** {CL_COMMAND_BUFFER_CAPABILITY_SIMULTANEOUS_USE_KHR}
** {CL_COMMAND_BUFFER_CAPABILITY_OUT_OF_ORDER_KHR}
* {cl_command_buffer_properties_khr_TYPE}
** {CL_COMMAND_BUFFER_FLAGS_KHR}
* {cl_command_buffer_flags_khr - bitfield_TYPE}
* {cl_command_buffer_flags_khr_TYPE}
** {CL_COMMAND_BUFFER_SIMULTANEOUS_USE_KHR}
* {Error codes_TYPE}
* New <<error_codes, Error Codes>>
** {CL_INVALID_COMMAND_BUFFER_KHR}
** {CL_INVALID_SYNC_POINT_WAIT_LIST_KHR}
** {CL_INCOMPATIBLE_COMMAND_QUEUE_KHR}
Expand Down
5 changes: 4 additions & 1 deletion api/opencl_runtime_layer.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -14129,7 +14129,10 @@ returned in _errcode_ret_:
specified by {CL_DEVICE_COMMAND_BUFFER_REQUIRED_QUEUE_PROPERTIES_KHR}.
* {CL_INVALID_CONTEXT} if all the command-queues in _queues_ do not have
the same OpenCL context.
* {CL_INVALID_VALUE} if _num_queues_ is zero.
* {CL_INVALID_VALUE} if the `<<cl_khr_command_buffer_multi_device>>`
extension is supported and _num_queues_ is zero, or if the
`<<cl_khr_command_buffer_multi_device>>` extension is not supported
and _num_queues_ is not one.
* {CL_INVALID_VALUE} if _queues_ is `NULL`.
* {CL_INVALID_VALUE} if values specified in _properties_ are not valid, or
if the same property name is specified more than once.
Expand Down

0 comments on commit 92cb7d8

Please sign in to comment.