Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP cl_ext_image_drm_format_modifier #1019

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kpet
Copy link
Contributor

@kpet kpet commented Nov 28, 2023

No description provided.

Change-Id: I6c391b5ecaa203f7db566db68a7e3d124d6038a2
Signed-off-by: Kevin Petit <[email protected]>
Change-Id: I30630ac1232026301356e0265b074b8b41668cb2
Signed-off-by: Kevin Petit <[email protected]>
@bcalidas
Copy link

bcalidas commented Dec 5, 2023

Sharing some initial feedback.

  1. For cl_ext_image_tiling_control, is there really a need for the CL_DEVICE_IMAGE_TILING_DEVICE_ACCESS_EXT token.

  2. For cl_ext_image_tiling_control does CL_DEVICE_IMAGE_TILING_HOST_ACCESS_EXT relate to whether or not the implementation will detile the image on mapping?

  3. For cl_ext_image_tiling_control, is there an assumption that the image is linear if no explicit tiling mode is forced. To us it seemed that the spec implicitly suggested optimal tiling by default.

  4. For cl_ext_image_drm_format_modifer, why would a drm format modifier be required for an image. Shouldn't drm format modifiers be viewed as a decoration of top of optimal tiling. Our thinking was that drm format modifiers would be applied only when importing an optimally tiled image. Additionally, they could be queried for any image ( including linear ) but an application would only make the query when exporting an image.

  5. For cl_ext_image_drm_format_modifier, how are we planning to manage the drm format modifier header file from the implementation side and from the application side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants