-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix section titles in Appendix I - OpenCL extensions #1087
Conversation
The section headers for "Name String", "Ratification Status", etc should be one level below the headers for individual extensions. Another, possibly cleaner, way to fix this would be to add one level of nesting to headers in all the extension files under api/ Signed-off-by: Kevin Petit <[email protected]> Change-Id: I97bc12a845ccb39c421dfed16223b3cdee5203af
@oddhack do you have a preference how we do this? I agree the spec TOC looks much nicer after this change. |
I did something along these lines in the Vulkan scripts quite recently as well - let me take another pass at syncing up the scripts, as I'd like to keep those linked up between the various repos making use of them. It is a bit tricky because the refpage extraction script that assembles the extension refpages has to make some assumptions about the heading level of the extension appendix bits it extracts. (Edit: TL;DR please hold off on this one for a bit if it is not urgent.) |
…n nesting The observable effects of this are - Pushes the subsection titles in the extension appendices down one level, similar to #1087 but keeping the scripts in sync - Adds an autogenerated 'API Interactions' section with currently only affects the cl_khr_command_buffer extension, since that's the only one with some APIs tagged in the XML as dependent on a particular core version
Please take a look at #1116 as an alternative. The nesting level adjustment falls out of synchronizing the scripts with the Vulkan scripts. |
…n nesting (#1116) The observable effects of this are - Pushes the subsection titles in the extension appendices down one level, similar to #1087 but keeping the scripts in sync - Adds an autogenerated 'API Interactions' section with currently only affects the cl_khr_command_buffer extension, since that's the only one with some APIs tagged in the XML as dependent on a particular core version
@oddhack Thanks! Closing this PR. |
The section headers for "Name String", "Ratification Status", etc should be one level below the headers for individual extensions.
Another, possibly cleaner, way to fix this would be to add one level of nesting to headers in all the extension files under api/
Change-Id: I97bc12a845ccb39c421dfed16223b3cdee5203af