Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cl_ext_image_requirements_info into unified specification #1295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kpet
Copy link
Contributor

@kpet kpet commented Jan 6, 2025

Change-Id: Ia249f78aa521a8d202dfafbb736c9887574e56f9

Signed-off-by: Kevin Petit <[email protected]>
Change-Id: Ia249f78aa521a8d202dfafbb736c9887574e56f9
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do a detailed text review, but I did a quick skim and everything looks like it's in the right place. Other than a few minor editorial issues, LGTM.

@@ -5112,6 +5136,171 @@ returned in _errcode_ret_:
--
endif::cl_khr_gl_sharing[]

ifdef::cl_ext_image_requirements_info[]
=== Querying image requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial nitpick: we usually use title case for section headers.

Suggested change
=== Querying image requirements
=== Querying Image Requirements

If _param_value_size_ret_ is `NULL`, it is ignored.

[[image-requirements-info-table]]
.List of supported param_names by <<clGetImageRequirementsInfoEXT>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.List of supported param_names by <<clGetImageRequirementsInfoEXT>>
.List of supported param_names by {clGetImageRequirementsInfoEXT}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants