-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command-buffer context query #899
Merged
bashbaug
merged 1 commit into
KhronosGroup:main
from
EwanC:ewan/command-buffer_context_query
Apr 4, 2023
Merged
Add command-buffer context query #899
bashbaug
merged 1 commit into
KhronosGroup:main
from
EwanC:ewan/command-buffer_context_query
Apr 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce query `CL_COMMAND_BUFFER_CONTEXT_KHR` for the `cl_context` associated with a command-buffer. This PR uses enum value `0x1299` which is also attempting be used by another command-buffer PR KhronosGroup#850 However, that PR still needs review so would prefer to use that enum here as `0x1299` is contiguous with the other command-buffer query enums, and I can find a new value for PR KhronosGroup#850 Closes KhronosGroup#898
EwanC
force-pushed
the
ewan/command-buffer_context_query
branch
from
March 31, 2023 11:59
6138061
to
e1bc510
Compare
EwanC
added
the
OpenCL Extension Spec
Issues related to the OpenCL Extension specification.
label
Mar 31, 2023
kpet
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! We should capture work to update the CTS tests as well.
EwanC
added a commit
to EwanC/OpenCL-Headers
that referenced
this pull request
Apr 4, 2023
Define `0x1299` as `CL_COMMAND_BUFFER_CONTEXT_KHR` to reflect merged spec PR KhronosGroup/OpenCL-Docs#899 See also original issue KhronosGroup/OpenCL-Docs#898
EwanC
added a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Apr 5, 2023
Test coverage for spec PR KhronosGroup/OpenCL-Docs#899 which introduces a new cl_khr_command_buffer query for the cl_context
EwanC
added a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Apr 5, 2023
Test coverage for spec PR KhronosGroup/OpenCL-Docs#899 which introduces a new cl_khr_command_buffer query for the cl_context
bashbaug
pushed a commit
to KhronosGroup/OpenCL-Headers
that referenced
this pull request
Apr 9, 2023
Define `0x1299` as `CL_COMMAND_BUFFER_CONTEXT_KHR` to reflect merged spec PR KhronosGroup/OpenCL-Docs#899 See also original issue KhronosGroup/OpenCL-Docs#898
EwanC
added a commit
to KhronosGroup/OpenCL-CTS
that referenced
this pull request
Jun 28, 2023
Test coverage for spec PR KhronosGroup/OpenCL-Docs#899 which introduces a new cl_khr_command_buffer query for the cl_context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-cts-coverage
The CTS needs to be extended
OpenCL Extension Spec
Issues related to the OpenCL Extension specification.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce query
CL_COMMAND_BUFFER_CONTEXT_KHR
for thecl_context
associated with a command-buffer.This PR uses enum value
0x1299
which is also attempting to be used by another command-buffer PR #850 However, that PR still needs reviewed, so would prefer to use that enum here as0x1299
is contiguous with the other command-buffer query enums, and I can find a new value for PR #850Closes #898