Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-buffer context query #899

Merged

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Mar 31, 2023

Introduce query CL_COMMAND_BUFFER_CONTEXT_KHR for the cl_context associated with a command-buffer.

This PR uses enum value 0x1299 which is also attempting to be used by another command-buffer PR #850 However, that PR still needs reviewed, so would prefer to use that enum here as 0x1299 is contiguous with the other command-buffer query enums, and I can find a new value for PR #850

Closes #898

@EwanC EwanC requested a review from kpet March 31, 2023 11:58
Introduce query `CL_COMMAND_BUFFER_CONTEXT_KHR` for the
`cl_context` associated with a command-buffer.

This PR uses enum value `0x1299` which is also attempting
be used by another command-buffer PR
KhronosGroup#850
However, that PR still needs review so would prefer
to use that enum here as `0x1299` is contiguous with
the other command-buffer query enums, and I can find a new
value for PR KhronosGroup#850

Closes KhronosGroup#898
@EwanC EwanC force-pushed the ewan/command-buffer_context_query branch from 6138061 to e1bc510 Compare March 31, 2023 11:59
@EwanC EwanC added the OpenCL Extension Spec Issues related to the OpenCL Extension specification. label Mar 31, 2023
Copy link
Contributor

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! We should capture work to update the CTS tests as well.

@kpet kpet added the needs-cts-coverage The CTS needs to be extended label Mar 31, 2023
@bashbaug bashbaug merged commit 9a7dfe0 into KhronosGroup:main Apr 4, 2023
EwanC added a commit to EwanC/OpenCL-Headers that referenced this pull request Apr 4, 2023
Define `0x1299` as `CL_COMMAND_BUFFER_CONTEXT_KHR` to reflect merged
spec PR KhronosGroup/OpenCL-Docs#899

See also original issue KhronosGroup/OpenCL-Docs#898
EwanC added a commit to EwanC/OpenCL-CTS that referenced this pull request Apr 5, 2023
Test coverage for spec PR KhronosGroup/OpenCL-Docs#899
which introduces a new cl_khr_command_buffer query for the cl_context
EwanC added a commit to EwanC/OpenCL-CTS that referenced this pull request Apr 5, 2023
Test coverage for spec PR KhronosGroup/OpenCL-Docs#899
which introduces a new cl_khr_command_buffer query for the cl_context
bashbaug pushed a commit to KhronosGroup/OpenCL-Headers that referenced this pull request Apr 9, 2023
Define `0x1299` as `CL_COMMAND_BUFFER_CONTEXT_KHR` to reflect merged
spec PR KhronosGroup/OpenCL-Docs#899

See also original issue KhronosGroup/OpenCL-Docs#898
EwanC added a commit to KhronosGroup/OpenCL-CTS that referenced this pull request Jun 28, 2023
Test coverage for spec PR KhronosGroup/OpenCL-Docs#899
which introduces a new cl_khr_command_buffer query for the cl_context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cts-coverage The CTS needs to be extended OpenCL Extension Spec Issues related to the OpenCL Extension specification.
Development

Successfully merging this pull request may close these issues.

Missing CL_COMMAND_BUFFER_CONTEXT_KHR query
3 participants