Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an error condition when unmapping a SVM region that was not mapped #979

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add an error condition when unmapping a SVM region that was not mapped #979

wants to merge 1 commit into from

Conversation

bashbaug
Copy link
Contributor

fixes #890

Adds an error condition (CL_INVALID_VALUE) when attempting to unmap a SVM region that was not mapped.

@bashbaug bashbaug marked this pull request as draft October 16, 2023 22:59
@bashbaug bashbaug mentioned this pull request Oct 17, 2023
Open
alycm
alycm approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@alycm alycm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially approved, but editing to drop that for now.

LGTM textually. Still significant amount of discussion in #890.

@alycm alycm self-requested a review November 28, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alycm alycm Awaiting requested review from alycm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clEnqueueSVMUnmap
2 participants
@bashbaug @alycm