Added support for pkg-config. #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerilk
commented
Oct 10, 2022
Kerilk
commented
Oct 11, 2022
Kerilk
commented
Oct 11, 2022
Contributor
|
See here. |
Kerilk
force-pushed
the
pkg-config
branch
4 times, most recently
from
3d72f18 to
f326895
Compare
Contributor
Author
|
@MathiasMagnus If this looks good to you, I'll do the same for the loader PR. |
MathiasMagnus
previously approved these changes
Oct 18, 2022
Kerilk
commented
Dec 13, 2022
Contributor
Author
|
If @MathiasMagnus thinks it is good, I thing we're good to go @bashbaug . This will allow merging the loader one with tests passing. |
bashbaug
approved these changes
Jan 10, 2023
Contributor
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
Merging as discussed in the OpenCL teleconferences. This will give time for testing before the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for pkg-config using two independent packages for OpenCL headers and loader library as discussed here KhronosGroup/OpenCL-ICD-Loader#190
We may want to think about versioning here.