Supported an OPENCL_VISIBLE_DEVICES environment variable inspired fro… #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m CUDA_VISIBLE_DEVICES. OPENCL_VISIBLE_DEVICES=descriptor_list descriptor_list -> descriptor | descriptor::descriptor_list descriptor -> driver,platform | driver,platform,type | driver,platform,type,device_list device_list -> device_id | device_id,device_list driver: client driver (foo.icd or foo.so) platform: platform ID type: gpu, cpu, accelerator, custom, or any device_id: device ID in the platform This patch is to land KhronosGroup#45 again. Most of the code is from pull request 45. e.g., OPENCL_VISIBLE_DEVICES=foo.icd,0,gpu,0,1::bar.icd,1,cpu,0 only shows - GPU 0, 1 in the first platform of foo.icd - CPU 0 in the second platform of bar.icd
jenatali
reviewed
Jul 27, 2021
Contributor
jenatali
left a comment
jenatali
left a comment
There was a problem hiding this comment.
It seems to me that this would be more appropriate as a layer, now that those are available, rather than building it straight into the loader, but perhaps someone with more expertise on layers would like to comment.
| num_devices); | ||
| #endif // defined(CL_ENABLE_LAYERS) | ||
| KHR_ICD_VALIDATE_HANDLE_RETURN_ERROR(platform, CL_INVALID_PLATFORM); | ||
| return platform->dispatch->clGetDeviceIDs( |
Contributor
There was a problem hiding this comment.
This is a generated file. You don't want to modify this, you want to modify the generator.
Contributor
Author
There was a problem hiding this comment.
sorry. I closed this PR by mistake and I created PR 153. Please review.
I updated the icd_dispatch_generated.c file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…m CUDA_VISIBLE_DEVICES.
OPENCL_VISIBLE_DEVICES=descriptor_list
descriptor_list -> descriptor | descriptor::descriptor_list
descriptor -> driver,platform | driver,platform,type | driver,platform,type,device_list
device_list -> device_id | device_id,device_list
driver: client driver (foo.icd or foo.so)
platform: platform ID
type: gpu, cpu, accelerator, custom, or any
device_id: device ID in the platform
This patch is to land #45 again.
Most of the code is from pull request 45.
e.g., OPENCL_VISIBLE_DEVICES=foo.icd,0,gpu,0,1::bar.icd,1,cpu,0 only shows