Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transposed arguments to calloc #245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix transposed arguments to calloc #245

wants to merge 1 commit into from

Conversation

ldrumm
Copy link

@ldrumm ldrumm commented Nov 6, 2024

The signature to calloc is void *calloc(size_t nmemb, size_t size). gcc very helpfully caught this use and is now warning about it.

Good job, gcc!

@ldrumm
Fix transposed arguments to calloc
b00d588 
The signature to calloc is `void *calloc(size_t nmemb, size_t size)`.
gcc very helpfully caught this use and is now warning about it.

Good job, gcc!
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

bashbaug
bashbaug approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after the CLA is taken care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldrumm @CLAassistant @bashbaug