Drop extra install rules#126
Conversation
05ed79f to
abe0e7b
Compare
Beanavil
left a comment
There was a problem hiding this comment.
The change LGTM, thanks for noticing this! It actually also uncovers a bug in the already-existing install command for the Utils and the Extensions that comes from the same commit that introduced the duplicated install(). IINM all target types should be part of the same component, for instance for the utils something like the following should be done:
install(
TARGETS ${UTIL_LIB_TARGET}
EXPORT OpenCL${UTIL_LIB_NAME}Targets
ARCHIVE
DESTINATION ${CMAKE_INSTALL_LIBDIR}
COMPONENT binary
LIBRARY
DESTINATION ${CMAKE_INSTALL_LIBDIR}
COMPONENT binary
RUNTIME
DESTINATION ${CMAKE_INSTALL_BINDIR}
COMPONENT binary
)abe0e7b to
0bab365
Compare
good catch! Updated. |
|
Hi, can you please sign the CLA so we can accept this change? Sometimes the CLA bot can get stuck, so if you've already done this let us know and we'll see if we can get it un-stuck. Thanks! |
Signed-off-by: Ilya Lavrenov <ilya.lavrenov@intel.com>
0bab365 to
8120a6a
Compare
done |
|
Hi @ilya-lavrenov , the CLA task still doesn't show complete. Can you please check that everything looks right on your end? If so, we'll need to figure out what's going on with the bot - thanks! |
done |
See https://github.com/KhronosGroup/OpenCL-SDK/pull/88/files#r1905072265