MSL: Fix patch vertex count with raw buffer tese input. #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reference/opt/shaders-msl/tese/read-patch-vertices-in-func.raw-tess-in.tese
Outdated
Show resolved
Hide resolved
We can no longer rely on the `patch_control_point<>` array being present, so the best we can do is use the value given us at compile time. This was an oversight on my part when I initially implemented the raw-buffer tessellation evaluation input mode. The lack of tests for the `PatchVertices` built-in almost certainly contributed, so I fixed that in this patch. Fixes the test `dEQP-VK.tessellation.shader_input_output.patch_vertices_in_tes`. This is the last failing test under `dEQP-VK.tessellation`.
cdavis5e
force-pushed
the
raw-tese-input-patch-vertices
branch
from
573e751
to
c0760eb
Compare
HansKristian-Work
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can no longer rely on the
patch_control_point<>array being present, so the best we can do is use the value given us at compile time.This was an oversight on my part when I initially implemented the raw-buffer tessellation evaluation input mode. The lack of tests for the
PatchVerticesbuilt-in almost certainly contributed, so I fixed that in this patch.Fixes the test
dEQP-VK.tessellation.shader_input_output.patch_vertices_in_tes. This is the last failing test underdEQP-VK.tessellation.