Header changes for Intel's Task Sequence extension #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiwaria1
changed the title
|
There are some odd differences. Is possible some headers were hand edited? Either way, there are some odd spacing distances. |
Yes most of this was hand edited. Could you point any specific issue for example? btw I have left this in draft form until I get the SPIRV spec merged to Khronos repo. |
|
Needs a rebase before merging. I'd recommend doing a careful update of spirv.core.grammar.json and then re-generating, since it seems that there were generation issues previously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement header changes for the task sequence extension: KhronosGroup/SPIRV-Registry#192