Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce redundancy in utility functions #430

Closed
wants to merge 2 commits into from
Closed

Conversation

mmoult
Copy link

@mmoult mmoult commented May 29, 2024

Commit acfc25 introduced helpful utility functions to the C/C++ headers, but they have a lot of redundancy. These functions have long switch statements with trivial logic- ideal conditions for #defines. I did not see any style guide (perhaps the redundancy is unavoidable if #defines are forbidden), so I wrote this change.

Undoubtedly there are style considerations to do it the Khronos way. I figured I could submit this proposal and you can do with it what you will.

Reduce redundancy in C/C++ spirv utility functions.
@CLAassistant
Copy link

CLAassistant commented May 29, 2024

CLA assistant check
All committers have signed the CLA.

@alan-baker
Copy link
Contributor

These headers are all auto-generated. As it stands any future generation would override these changes. Take a look in the tools/buildHeaders directory for the code. I haven't thought too hard about the proposed changes themselves yet though.

@mmoult mmoult closed this May 31, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants