Reduce redundancy in utility functions #430
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit
acfc25
introduced helpful utility functions to the C/C++ headers, but they have a lot of redundancy. These functions have long switch statements with trivial logic- ideal conditions for#define
s. I did not see any style guide (perhaps the redundancy is unavoidable if#define
s are forbidden), so I wrote this change.Undoubtedly there are style considerations to do it the Khronos way. I figured I could submit this proposal and you can do with it what you will.