handle OpBitcast between pointers and non-pointers #2948
+96
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though we only expect to OpBitcast a pointer to a vector of two 32-bit integers, it's easy enough to just handle all vector types.
svenvh
reviewed
Jan 3, 2025
| OpMemoryModel Physical64 OpenCL | ||
| OpEntryPoint Kernel %kernel "test" | ||
| %uint = OpTypeInt 32 0 | ||
| %ulong = OpTypeInt 64 0 |
| @@ -1085,6 +1085,37 @@ Value *SPIRVToLLVM::transConvertInst(SPIRVValue *BV, Function *F, | |||
| case OpFConvert: | |||
| CO = IsExt ? Instruction::FPExt : Instruction::FPTrunc; | |||
| break; | |||
| case OpBitcast: | |||
| CO = Instruction::BitCast; | |||
There was a problem hiding this comment.
Perhaps it would be nice to add a comment here to highlight the difference between OpBitcast and llvm's bitcast (repeating the PR description would work for me).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for SPIR-V OpBitcast instructions where the source is a pointer and the destination is not a pointer, and where the source is not a pointer and the destination is a pointer. This needs to be handled as a special case because the LLVM bitcast instruction does not support this.
Handles bitcasts between pointers and scalar integers, which is supported by all SPIR-V versions, and pointers and vectors of integers, which is supported by SPIR-V 1.5 (though only for vectors of 32-bit integers).