Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Address Sanitization to CI build #223

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Add Address Sanitization to CI build #223

merged 2 commits into from
Sep 12, 2023

Conversation

spencer-lunarg
Copy link
Contributor

  • First commit just ran dos2unix on CMake file
  • 2nd commit is adding an option to run with -fsanitize=address in CI to catch any potential issues (which currently there are none!)
    • Also run Release version in CI as that is what ends up in the SDK

@spencer-lunarg
Copy link
Contributor Author

CI with ASAN - 13 minutes
CI without ASAN - 3 minutes

So there is a noticeable increase in time, but feel with the frequency of PRs, this extra 10 minutes isn't going to block anyone

@spencer-lunarg spencer-lunarg merged commit bd70cfa into KhronosGroup:main Sep 12, 2023
4 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-asan branch September 12, 2023 00:16
@spencer-lunarg spencer-lunarg mentioned this pull request Oct 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoticbob chaoticbob chaoticbob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencer-lunarg @chaoticbob