Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix specialization_constants items #268

Closed
wants to merge 1 commit into from
Closed

Fix specialization_constants items #268

wants to merge 1 commit into from

Conversation

dpwiz
Copy link

@dpwiz dpwiz commented Jun 30, 2024

specialization_constants block is missing item markers and the resulting YAML is treated like a map, failing on duplicate keys (spirv_id).

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@spencer-lunarg
Copy link
Contributor

@dpwiz sorry - I just realized this and #274 were doing the same thing and I merged that one in first

@dpwiz dpwiz closed this Jul 12, 2024
@dpwiz dpwiz deleted the yaml-spec-constants branch July 12, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-lunarg spencer-lunarg spencer-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpwiz @CLAassistant @spencer-lunarg