Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPV_EXT_optnone extension #260

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

MrSidims
Copy link
Contributor

No description provided.

Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
Copy link
Contributor

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would be interested in seeing this extension published as an EXT instead.

@MrSidims MrSidims marked this pull request as draft August 7, 2024 09:59
@MrSidims
Copy link
Contributor Author

MrSidims commented Aug 7, 2024

I don't mind to change it from vendor extension to EXT. Converting to draft for now

Signed-off-by: Sidorov, Dmitry <[email protected]>
@MrSidims MrSidims changed the title Add SPV_INTEL_optnone extension Add SPV_EXT_optnone extension Aug 20, 2024
@MrSidims MrSidims marked this pull request as ready for review August 20, 2024 21:21
README.md Outdated Show resolved Hide resolved
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="generator" content="Asciidoctor 2.0.16">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was not generated with the version of asciidoctor provided in the docker image. We're working towards automatically generating and publishing specs (see #270) and one of the necessary steps involves making sure that all specs can be generated with the version provided in the docker image. It seems that we have not updated EXT extensions yet and this spec looks rather straightforward so I think re-generating the HTML needn't be a blocker to this PR going in (but would be nice to do if you can).

@bashbaug
Copy link
Collaborator

bashbaug commented Sep 4, 2024

Merging as discussed in the September 4th teleconference.

@bashbaug bashbaug merged commit 20cb776 into KhronosGroup:main Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants