Skip to content

Update logical pointer validation rules for SPV_NV_cluster_acceleration_structure and SPV_NV_linear_swept_spheres. #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update logical pointer validation rules for SPV_NV_cluster_acceleration_structure and SPV_NV_linear_swept_spheres. #354

wants to merge 3 commits into from
+48 −4

Conversation

dnovillo
Copy link

@dnovillo dnovillo commented Sep 2, 2025

See SPIR-V issue 878.

@dnovillo
Update logical pointer validation rules for SPV_NV_cluster_accelerati…
76a15e5 
…on_structure and SPV_NV_linear_swept_spheres.

See SPIR-V issue 878.
@dnovillo dnovillo requested a review from alan-baker September 2, 2025 20:58
alan-baker
alan-baker reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just the minor pre-existing issue in naming.

@dnovillo
Copy link
Author

dnovillo commented Sep 3, 2025

Changes look good, just the minor pre-existing issue in naming.

Actually, I've been chatting with the ray tracing folks. It seems that the grammar is wrong. The name should be OpRayQueryGetIntersectionClusterIdNV . I'll update the grammar as well.

@Naghasan
Copy link
Member

Naghasan commented Sep 3, 2025

I'll update the grammar as well.

Maybe best to update this using an alias (aliases entry) in order to avoid breaking changes

@dnovillo
Copy link
Author

dnovillo commented Sep 3, 2025

I'll update the grammar as well.

Maybe best to update this using an alias (aliases entry) in order to avoid breaking changes

Thanks. I'll do that.

@dnovillo dnovillo mentioned this pull request Sep 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-baker alan-baker alan-baker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnovillo @Naghasan @alan-baker