Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spirv-val: Validate zero product workgroup size #5407

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

spirv-val: Validate zero product workgroup size #5407

wants to merge 3 commits into from

Conversation

spencer-lunarg
Copy link
Contributor

Improved version of #4828

closes #4801

Created a EntryPointData reduce number of hash maps with the entry_point_id as the key

alan-baker
alan-baker requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still thinking about the change to save execution mode instructions. I'm not so sure about that.

source/val/validate_builtins.cpp Outdated Show resolved Hide resolved
source/val/validate_mode_setting.cpp Outdated Show resolved Hide resolved
@s-perron
Copy link
Collaborator

@alan-baker Any more thoughts?

@spencer-lunarg
Copy link
Contributor Author

@alan-baker I found there was a EntryPointLocalSizeOrId added from Coop Matrix and was able to reuse that and didn't need to touch at state tracking at all now.

I redid this PR (force pushed), its in 3 commits now for easier viewing as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-baker alan-baker alan-baker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing validation for static workgroup size dimensions nonzero product.
3 participants
@spencer-lunarg @s-perron @alan-baker