instrument: Fix handling of gl_InvocationID #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @Tony-LunarG and @spencer-lunarg This fixes instrumentation of the shader used by |
|
The smoketest failure is independent. Something changed in how glslang exports its libraries... |
jeremyg-lunarg
force-pushed
the
jeremyg-inst-tesc
branch
from
3ae7cc6
to
de3f46f
Compare
spencer-lunarg
approved these changes
Dec 5, 2023
This is an int and needs to be cast to a unit for inclusion in the stage specific data passed to the instrumentation check function.
jeremyg-lunarg
force-pushed
the
jeremyg-inst-tesc
branch
from
de3f46f
to
01d291f
Compare
jeremyg-lunarg
added a commit
to jeremyg-lunarg/Vulkan-ValidationLayers
that referenced
this pull request
Dec 5, 2023
jeremyg-lunarg
added a commit
to KhronosGroup/Vulkan-ValidationLayers
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an int and needs to be cast to a unit for inclusion in the stage specific data passed to the instrumentation check function.