[NFC] Apply small clang-tidy fixes #5709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Keenuts
commented
Jun 12, 2024
Keenuts
commented
- const for passed-by-value has no effect on prototypes.
- transitive includes.
- dead stores
- uses after move
dneto0
requested changes
Jun 17, 2024
|
rebased on main |
dneto0
previously requested changes
Oct 8, 2024
- const for passed-by-value has no effect on prototypes. - transitive includes. - dead stores - uses after move Signed-off-by: Nathan Gauër <[email protected]>
Signed-off-by: Nathan Gauër <[email protected]>
s-perron
approved these changes
Nov 12, 2024
s-perron
dismissed
dneto0’s stale review
The test was put back in, so David's concern's were addressed.
|
I don't know how this work yet am new. |
mmoult
pushed a commit
to mmoult/SPIRV-Tools
that referenced
this pull request
Nov 16, 2024
* [NFC] Apply small clang-tidy fixes - const for passed-by-value has no effect on prototypes. - transitive includes. - dead stores - uses after move Signed-off-by: Nathan Gauër <[email protected]> * pr-feedback Signed-off-by: Nathan Gauër <[email protected]> --------- Signed-off-by: Nathan Gauër <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.