spirv-opt: Fail gracefully on ID overflow during spec constant folding #6310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instruction folder returns nullptr when it fails to create a new instruction due to ID overflow. This is ambiguous because it also returns nullptr when it simply cannot fold an instruction. This change introduces an `id_overflow_` flag in `IRContext` that is set by `TakeNextId()` when it runs out of IDs. The `FoldSpecConstantOpAndCompositePass` is updated to check this flag after attempting to fold a spec constant. If the flag is set, the pass returns `Status::Failure`, preventing further processing and providing a clear error.
s-perron
force-pushed
the
id_overflow10
branch
from
c788b54 to
1893fcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instruction folder returns nullptr when it fails to create a new
instruction due to ID overflow. This is ambiguous because it also
returns nullptr when it simply cannot fold an instruction.
This change introduces an
id_overflow_flag inIRContextthat isset by
TakeNextId()when it runs out of IDs.The
FoldSpecConstantOpAndCompositePassis updated to check this flagafter attempting to fold a spec constant. If the flag is set, the pass
returns
Status::Failure, preventing further processing and providing aclear error.