-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dEQP-ism from generated CTS helpers #2396
Conversation
CTS no longer uses the de* types.
@oddhack not sure where vulkan_json_parser.hpp and vulkan_json_data.hpp are used outside CTS. If you know of any users, I'd appreciate it if you could verify that this change is a no-op for them. |
I believe these are Vulkan SC-specific. @dgkoch can you confirm and advise how to proceed? Putting it in the upstream like this seems OK if it's not an urgent fix. |
FWIW, VK-GL-CTS hasn't regenerated this for like 3 years, and I've noticed the generated files sometimes receive manual edits in that repo. This is not urgent, it's been a few months already since VK-GL-CTS has removed these types. |
Mobica is actually about to update these in VK-GL-CTS, so they'll probably be interested in this fix. I might cherry-pick this straight into the vulkansc repo, where we added another change recently. |
I've taken this to internal merge request: https://gitlab.khronos.org/vulkansc/vulkansc/-/merge_requests/382 |
Taking this off the Vulkan maintenance agenda - please close when appropriate. |
Something based on this was merged into VKSC branch and released in the VKSC 1.0.16 release, and was merged back up to Vulkan and published in the 1.3.299 release. |
CTS no longer uses the de* types.