Skip to content

Added KHRCreateRenderpass2ExtensionName to requiredDeviceExtension to… #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MortenKristiansen wants to merge 2 commits into from
Closed

Added KHRCreateRenderpass2ExtensionName to requiredDeviceExtension to… #266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6faa6c
Added KHRCreateRenderpass2ExtensionName to requiredDeviceExtension to…
MortenKristiansen Dec 30, 2025
519a413
Removed vk::KHRCreateRenderpass2ExtensionName as this is core since 1…
MortenKristiansen Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion attachments/09_shader_modules.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
Copy link
Collaborator

@SaschaWillems SaschaWillems Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only VK_KHR_shader_draw_parameters should be required. I don't think we need renderpass2 as that's core since 1.2 and we use 1.4.

Copy link
Contributor Author

@MortenKristiansen MortenKristiansen Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove it, however it was there originally. I'll test if the validation layer complains.

Copy link
Collaborator

@SaschaWillems SaschaWillems Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry my bad. If it was there, just leave it in place. I'm addressing extensions in #260

vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/10_fixed_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/12_graphics_pipeline_complete.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/14_command_buffers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/15_hello_triangle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/16_frames_in_flight.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/17_swap_chain_recreation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/18_vertex_input.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/19_vertex_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/20_staging_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/21_index_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/22_descriptor_layout.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/23_descriptor_sets.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/24_texture_image.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/25_sampler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/26_texture_mapping.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/27_depth_buffering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/28_model_loading.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/29_mipmapping.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/30_multisampling.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ class HelloTriangleApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/31_compute_shader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ class ComputeShaderApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/32_ecosystem_utilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ class HelloTriangleApplication
bool framebufferResized = false;

std::vector<const char *> requiredDeviceExtension = {
vk::KHRSwapchainExtensionName};
vk::KHRSwapchainExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/33_vulkan_profiles.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ class HelloTriangleApplication
};

const std::vector<const char *> requiredDeviceExtension = {
VK_KHR_SWAPCHAIN_EXTENSION_NAME};
vk::KHRSwapchainExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
3 changes: 2 additions & 1 deletion attachments/34_android.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,8 @@ class HelloTriangleApplication

// Required device extensions
const std::vector<const char *> deviceExtensions = {
VK_KHR_SWAPCHAIN_EXTENSION_NAME};
vk::KHRSwapchainExtensionName,
vk::KHRShaderDrawParametersExtensionName};

// Initialize Vulkan
void initVulkan()
Expand Down
3 changes: 2 additions & 1 deletion attachments/35_gltf_ktx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,8 @@ class VulkanApplication

std::vector<const char *> requiredDeviceExtension = {
vk::KHRSwapchainExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

#if PLATFORM_DESKTOP
void initWindow()
Expand Down
3 changes: 2 additions & 1 deletion attachments/36_multiple_objects.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,8 @@ class VulkanApplication

std::vector<const char *> requiredDeviceExtension = {
vk::KHRSwapchainExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

#if PLATFORM_DESKTOP
void initWindow()
Expand Down
3 changes: 2 additions & 1 deletion attachments/37_multithreading.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,8 @@ class MultithreadedApplication
vk::KHRSwapchainExtensionName,
vk::KHRSpirv14ExtensionName,
vk::KHRSynchronization2ExtensionName,
vk::KHRCreateRenderpass2ExtensionName};
vk::KHRCreateRenderpass2ExtensionName,
vk::KHRShaderDrawParametersExtensionName};

// Helper functions
[[nodiscard]] static std::vector<const char *> getRequiredExtensions()
Expand Down
3 changes: 2 additions & 1 deletion attachments/38_ray_tracing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ class VulkanRaytracingApplication
vk::KHRAccelerationStructureExtensionName,
vk::KHRBufferDeviceAddressExtensionName,
vk::KHRDeferredHostOperationsExtensionName,
vk::KHRRayQueryExtensionName};
vk::KHRRayQueryExtensionName,
vk::KHRShaderDrawParametersExtensionName};

void initWindow()
{
Expand Down
13 changes: 12 additions & 1 deletion en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/01_Shader_modules.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,13 +520,24 @@ Modifying the structure to suit the fragment shader is easy:
vk::PipelineShaderStageCreateInfo fragShaderStageInfo{ .stage = vk::ShaderStageFlagBits::eFragment, .module = shaderModule, .pName = "fragMain" };
----

Finish by defining an array that contains these two structs, which we'll later use to reference them in the actual pipeline creation step.
Defining an array that contains these two structs, which we'll later use to reference them in the actual pipeline creation step.

[,c++]
----
vk::PipelineShaderStageCreateInfo shaderStages[] = {vertShaderStageInfo, fragShaderStageInfo};
----

Finish by adding DrawParameters to the deviceExtensions. Otherwise the
Copy link
Collaborator

@SaschaWillems SaschaWillems Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a good explanation. Can you rephrase this so people understand why this is required when using Slang?

Copy link
Contributor Author

@MortenKristiansen MortenKristiansen Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barely :-) I've just started learning Vulkan - working through the tutorial, fixing things here and there to get it working.
As far as I can understand the SPIR compiler sets a flag or something in the bytecode signaling it's using parameters (though I don't see any at the moment). This cause the validation layer to complain the vk::KHRShaderDrawParametersExtensionName must be added.

What I can offer is to do some more research and come up with a better explanation. However, I can't make it tonight.

Copy link
Collaborator

@SaschaWillems SaschaWillems Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to open issues for stuff like that instead. We'll then take a look and add a proper explanation.

Copy link
Contributor Author

@MortenKristiansen MortenKristiansen Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll cancel this PR.

validation layers will complain:

[,c++]
----
std::vector<const char*> deviceExtensions = {
...
vk::KHRShaderDrawParametersExtensionName
};
----

That's all there is describing the programmable stages of the pipeline.
In the xref:./02_Fixed_functions.adoc[next chapter,] we'll look at the fixed-function stages.

Expand Down