Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DUG-348: fix for UI and seamless upgrade of on-demand features #25

Merged
merged 1 commit into from
Jun 17, 2024
Merged

DUG-348: fix for UI and seamless upgrade of on-demand features #25

merged 1 commit into from
Jun 17, 2024

Conversation

arek-xeb
Copy link

@arek-xeb arek-xeb commented Jun 17, 2024 •
edited
Loading

  1. Manual copy of fix for UI issue introduced in 0.38 release of upstream
    discussion: 'feast.ui_server' is not a package feast-dev/feast#4241
    fix: https://github.com/feast-dev/feast/pull/4248/files
  2. quick amend to make upgrade on environments painless regarding on-demand features: when they are read during initial step of apply from registry, feast is unpacking protobuf with non-nullable string for mode parameter resulting in empty string which does not fall under standard default value provisions in python code, hence extra line

THIS CHANGE SHOULD BE DISCARDED IN NEXT UPDATE OF FEAST VERSION FROM UPSTREAM

@arek-xeb arek-xeb merged commit a61aaf3 into master Jun 17, 2024
15 of 20 checks passed
@arek-xeb arek-xeb mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richa-lad-ki richa-lad-ki richa-lad-ki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arek-xeb @richa-lad-ki