-
Notifications
You must be signed in to change notification settings - Fork 743
Added new RF module E22-900M30S-SX1262 #2826
base: master
Are you sure you want to change the base?
Conversation
Hi @TheSillyMouse , i am not a librarian, i just want to point out that VCC and GND pins should be stacked, this will allow the symbol to become smaller in width. Thank you for this addition. |
Thank you for your comment. Is that mandatory? |
Hi @TheSillyMouse , according to KLC S4.3 rules for pin stacking, i think it is.. |
b4adb51
to
d8de692
Compare
@aris-kimi Fixed! |
d8de692
to
ebcb796
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TheSillyMouse , thank you for this fix.
Now you should
-
add a link to the footprint PR.
-
check travis output and try to fix its output leaving as an error only violating S5.1
-
change description to something like
2.5-5V, 1W, 12km, 850~930MHz, 30dBm
-
change keywords to something like
lora rf wireless module
-
add footprint filter something like
E22*900M30S*SX1262*
-
adjust symbol's width and height by 200mil
To correct footprint errors better wait for the footprint PR to merge.
ebcb796
to
fe5b49c
Compare
Thanks for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSillyMouse I do not think force-push is acceptable or might be a reason for conflicts, description though, should be comma seperated, check other symbols and try to spot differences.
I didn't see any change at travis errors..
fe5b49c
to
cfaa09f
Compare
Okay I'll push separated commits. |
Hello @TheSillyMouse thanks for this symbol. And thanks to @aris-kimi for the comments. I will add the followings:
Joel |
@TheSillyMouse ping |
No news of the author, indicate this is Abandoned |
Added new RF module E22-900M30S-SX1262
Datasheet
http://www.ebyte.com/en/downpdf.aspx?id=453
Screenshot
Footprint
KiCad/kicad-footprints#2345
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.