-
Notifications
You must be signed in to change notification settings - Fork 743
Libraries for Western Design Center 6500 series ICs. #2862
Conversation
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20 MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20 MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 Removed all footprint filters since there are already compatible ones associated with. Centered all symbols. Fixed the doubled Pin 24 in the QSOP24. Rechecked all pin numbers and associated names.
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20 MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 Added apropriate footprint filters.
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20 MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 However they are all off center by +10mil in Y axis to maintain the 100mil pin grid and symmetry.
…FN24, -QSOP24 Violated KLC Rules: S3.1 Reason: To maintain the 100mil pin grid spacing all symbols off centered by (0,+50) Datasheet: https://www.silabs.com/documents/public/data-sheets/efm8ub3-datasheet.pdf
… (note the second appearing digit)
* Includes symbols for CPU ICs: ** 65C02 ** 65C816 * Includes symbols for Interface ICs: ** 65C21 ** 65C22 ** 65C51 * Passes all tests from KLC helper scripts.
* Included recent additions to repository * Lines sorted in lexicographically ascending order.
* 65C134 * 65C265 Passes all tests from KLC helper scripts.
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 Changed VDD from Power Input to Passive since it can source power from the internal 5V LDO regulator aswell.
Hi, please add screenshots and provide links to datasheets. Without them a review is really hard. Related: #2780 |
Hi there. I included links to the datasheets within each of the new symbols. If I am supposed to include the same links within the merge request to make the reviewers' job easier, then the merge request instructions should probably be updated to reflect that. The datasheets used were:
Here is a PDF of all of the symbols across the three libraries: -Neil |
Accepting this would obviate the need for my PR, #2780, which only adds the w65c816s. |
Then please double check the work done in this PR and make sure that the symbols are correct. I don't claim to always be correct, and I don't claim that my layout is the only way it should be done. I've based the symbol designs themselves on example schematics from WDC. For example the W65C02 symbol is based on the schematic for the W65C02DB Developer Board. |
For the |
* Change address pins (A##) from Tri-State to Output * Stack power input pins (VDD and VSS)
* Change duplicate stacked power input pins to passive.
Yes but not only:
Anyway I never ask absolutely for the image, but for the above reasons I clearly start the review of symbols with an image, description of the modifications, datasheet link etc as requested in the template. When the symbol is reviewed I never ask to update the image too. But sometimes it can be nice and helpful. |
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 Adjusted description and filter accordingly
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 Grouped pins according their ports and major purpose. Changed electrical type of VDD from passive to power input. Changed electrical type of C2K and C2D to bidirectional. Changed pin length from 150mil to 100mil. Violated KLC Rules: S3.1: Smybols are off-centered by (0, 50) in order to maintain 100mil grid. EFM8UB30F40G-A-QFN20 Added missing pin 11 (P1.2)
@myfreescalewebpage I have since included a PDF of all of the symbols in a single schematic at https://github.com/KiCad/kicad-symbols/files/5087759/6500.Series.pdf Is this sufficient, or should the images be screen captures from within the Symbol Editor? If they should be individual images from within Symbol Editor, then perhaps the documentation should be updated to reflect this? |
* Added BQ78350-R1 Updated description Fix KLC S3.6 Fix KLC S4.1 Symbol is a little smaller * Change two pins type to putput * Changed keywords * Change VEN to open collector and SCL to output * Rename symbol, Add package name and size in description, Change pin 11 and 13 to bidirectional
* add ADA4610 operational amplifiers * ada4610: integrate review feedback * ADA4610-2xRM alias to NCS2325DM * ADA4610-2xCP: correct pre-selected footprint * ADA4610-2xCP: fix footprint filter
* add OPA569 high-current opamp in SO-20 PowerPAD * fix some klc issues * reduce x-size to get symmetry * footprint * fix footprint assignment and filter * update name and fp-filter
The STM32L4x1 SoC do not have USB support and thus no VDDUSB pin. A simple VDD pin is used instead. This probably comes from a copy and paste issue from other another SoC in the family.
* Add MAX941 * Improve MAX941 symbol * MAX941: Pin 6 V-; keyword single comparator; splited into three atomic parts (SOIC, PDIP and MSOP package) * MAX941: Package in description; MAX941xUA name and Fp filter
* Add MS5525DSO Pressure-Sensor * Improve Pins * Improve Pins - 2nd time * Center pins on the right side
* Added BM78 Class 2 Bluetooth/BLE module * BM78: Change pin length * BM78SPPS5MC2: Change name * BM78SPPS5MC2: set PMULDO_0 as passive pin * BM78SPPS5MC2: change RST_N pin name to ~RST * BM78SPPS5MC2: group P1xxx pins together * BM78SPPS5MC2: Change pin 13 and pin 14 names * BM78SPPS5MC2: Change ref and name location * BM78SPPS5NC2: Add alias to BM78SPPS5MC2 * BM78SPPS5MC2: Set footprint * BM78SPPS5MC2: Add footprint filter * BM78SPPS5NC2: Reorder P1_X pins and change symbol width * BM78SPPS5NC2: fix symbol center
Symbol derived from Johanson 5400BL15B050, changing pin 6 from NC to GND. Datasheets: https://www.johansontechnology.com/datasheets/0433BM15A0001/0433BM15A0001.pdf https://www.johansontechnology.com/datasheets/0868BM15C0001/0868BM15C0001.pdf https://www.johansontechnology.com/datasheets/0896BM15A0001/0896BM15A0001.pdf https://www.johansontechnology.com/datasheets/0915BM15A0001/0915BM15A0001.pdf
* add RJ45 LAN transformer Würth 74920111211 * 74980111211: fix datasheet URL & selected footprint
* Added PN512 RFID module * pn512: Update description * pn512: Update size, pins and name * Set pin 14 TVSS invisible and passive * Set EP visible
* add PN532_C1 * Switch order between I0/I1 Switch text order in P34
* Includes symbols for CPU ICs: ** 65C02 ** 65C816 * Includes symbols for Interface ICs: ** 65C21 ** 65C22 ** 65C51 * Passes all tests from KLC helper scripts.
* Included recent additions to repository * Lines sorted in lexicographically ascending order.
* 65C134 * 65C265 Passes all tests from KLC helper scripts.
* Change address pins (A##) from Tri-State to Output * Stack power input pins (VDD and VSS)
* Change duplicate stacked power input pins to passive.
…bol name * Switched all pins within CPU_WDC_6500.lib that were using graphic style "Inverted" to instead have a bar symbol over the name and a regular "Line" graphic style.
…bol name * Switched all pins within MCU_WDC_6500.lib that were using graphic style "Inverted" to instead have a bar symbol over the name and a regular "Line" graphic style. * Also switched remaining Tri-state pins to Bidirectional.
…bol name * Switched all pins within Interface_WDC_6500.lib that were using graphic style "Inverted" to instead have a bar symbol over the name and a regular "Line" graphic style. * Also switched remaining Tri-state pins to Bidirectional.
Did you rebase this branch? Or why are there 129 commits?
|
@cp-aquila Based on the suggestion from @myfreescalewebpage I did rebase against master to remove the changes I'd performed on sym-lib-table. Since this pull request has a near zero chance of being merged into master before everything moves to GitLab anyway, I'm going to just close this pull request and recreate it at GitLab some other time. -Neil |
ok @McNeight |
@McNeight, thanks for all the work you put into this. I wish it could have been merged. I hope that after the transition to GitLab, things can progress more quickly. With the Ben Eater videos, and such it seems that there is renewed interest, and this will be valuable to a number of hobbyists, myself included, and the 6502 community. |
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.