Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Libraries for Western Design Center 6500 series ICs. #2862

Closed
wants to merge 129 commits into from

Conversation

McNeight
Copy link

@McNeight McNeight commented Jul 17, 2020

  • Includes symbols for CPU ICs:
IC Datasheet DIP PLCC QFN
W65C02 W65C02SxxPx-14 W65C02SxxPLx-14 W65C02SxxPQx-14
W65C816 W65C816SxxPx-14 W65C816SxxPLx-14 W65C816SxxPQx-14
  • Includes symbols for Interface ICs:
IC Datasheet DIP PLCC QFN
W65C21 W65C21SxxPx-14 W65C21SxxPLx-14
W65C22 W65C22SxxPx-14 W65C22SxxPLx-14
W65C51 W65C51NxxPx-14 W65C51NxxPLx-14 W65C51NxxPQx-14
  • Includes symbols for MCU ICs:
IC Datasheet PLCC QFN
W65C134 W65C134SxxPLx-8 W65C134SxxQx-8
W65C265 W65C265SxxPLx-8 W65C265SxxQx-8
  • Passes all tests from KLC helper scripts.

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

LeSpirou and others added 10 commits June 12, 2020 20:20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24

Removed all footprint filters since there are already compatible ones associated with.
Centered all symbols.
Fixed the doubled Pin 24 in the QSOP24.
Rechecked all pin numbers and associated names.
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24

Added apropriate footprint filters.
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24
However they are all off center by +10mil in Y axis to maintain the 100mil pin grid and symmetry.
…FN24, -QSOP24

Violated KLC Rules:
S3.1 Reason: To maintain the 100mil pin grid spacing all symbols off centered by (0,+50)

Datasheet: https://www.silabs.com/documents/public/data-sheets/efm8ub3-datasheet.pdf
* Includes symbols for CPU ICs:
** 65C02
** 65C816
* Includes symbols for Interface ICs:
** 65C21
** 65C22
** 65C51
* Passes all tests from KLC helper scripts.
@CLAassistant
Copy link

CLAassistant commented Jul 17, 2020

CLA assistant check
All committers have signed the CLA.

McNeight and others added 4 commits July 16, 2020 23:20
* Included recent additions to repository
* Lines sorted in lexicographically ascending order.
* 65C134
* 65C265
Passes all tests from KLC helper scripts.
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24

Changed VDD from Power Input to Passive since it can source power from the internal 5V LDO regulator aswell.
@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jul 21, 2020
@ghost
Copy link

ghost commented Aug 5, 2020

Hi,

please add screenshots and provide links to datasheets. Without them a review is really hard.

Related: #2780

@McNeight
Copy link
Author

Hi there.

I included links to the datasheets within each of the new symbols. If I am supposed to include the same links within the merge request to make the reviewers' job easier, then the merge request instructions should probably be updated to reflect that.

The datasheets used were:

Here is a PDF of all of the symbols across the three libraries:
6500 Series.pdf

-Neil

@na-g
Copy link

na-g commented Aug 19, 2020

Accepting this would obviate the need for my PR, #2780, which only adds the w65c816s.

@McNeight
Copy link
Author

Accepting this would obviate the need for my PR, #2780, which only adds the w65c816s.

Then please double check the work done in this PR and make sure that the symbols are correct. I don't claim to always be correct, and I don't claim that my layout is the only way it should be done.

I've based the symbol designs themselves on example schematics from WDC. For example the W65C02 symbol is based on the schematic for the W65C02DB Developer Board.

@na-g
Copy link

na-g commented Aug 19, 2020

@McNeight I think given the feedback I received on #2780, the address pins on the MPUs/MCUs should be OUTPUT.

@na-g
Copy link

na-g commented Aug 19, 2020

For the W65C816, W65C02, W65C134, and W65C51N, I can't find text in the datasheets indicating that a decoupling capacitor is needed on each VSS pin, so the VSS pins should be stacked as per https://kicad-pcb.org/libraries/klc/S4.3/ . Full disclaimer, I am not a reviewer and I don't have any designs in the tree. I think the image of the proposed symbols that the reviewers want is supposed to show the pin types. @cp-aquila, or @myfreescalewebpage could you verify that the info in this message is correct?

* Change address pins (A##) from Tri-State to Output
* Stack power input pins (VDD and VSS)
* Change duplicate stacked power input pins to passive.
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Aug 30, 2020

I think the image of the proposed symbols that the reviewers want is supposed to show the pin types. @cp-aquila, or @myfreescalewebpage could you verify that the info in this message is correct?

Yes but not only:

  • The image indicate the complexity of the pull request. Which is very nice to have when you are a reviewer because if you know you have 10 minutes free to make a small review then you will check for a simple symbol to review.
  • The image is clearly helpful when the design is to be reworded a lot. For example pin length, general position of pins, etc. In this case I indicate I have just checked globally the pull request but it is not a full review, and I make a first set of comments. I do not open the symbol on KiCad. When it looks better I check with KiCad at this time.
  • Depending the langage on your machine, the pin type is translated and personally I'm able to check when this is English of French, but that's all.
  • And finally the image is nice to have to document the pull request.

Anyway I never ask absolutely for the image, but for the above reasons I clearly start the review of symbols with an image, description of the modifications, datasheet link etc as requested in the template.

When the symbol is reviewed I never ask to update the image too. But sometimes it can be nice and helpful.

LeSpirou added 2 commits August 30, 2020 14:26
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24
Adjusted description and filter accordingly
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24

Grouped pins according their ports and major purpose.
Changed electrical type of VDD from passive to power input.
Changed electrical type of C2K and C2D to bidirectional.
Changed pin length from 150mil to 100mil.

Violated KLC Rules:
S3.1: Smybols are off-centered by (0, 50) in order to maintain 100mil grid.

EFM8UB30F40G-A-QFN20
Added missing pin 11 (P1.2)
@McNeight
Copy link
Author

@myfreescalewebpage I have since included a PDF of all of the symbols in a single schematic at https://github.com/KiCad/kicad-symbols/files/5087759/6500.Series.pdf

Is this sufficient, or should the images be screen captures from within the Symbol Editor? If they should be individual images from within Symbol Editor, then perhaps the documentation should be updated to reflect this?

jneiva08 and others added 24 commits September 22, 2020 13:50
* Added BQ78350-R1
Updated description
Fix KLC S3.6
Fix KLC S4.1
Symbol is a little smaller

* Change two pins type to putput

* Changed keywords

* Change VEN to open collector and SCL to output

* Rename symbol,
Add package name and size in description,
Change pin 11 and 13 to bidirectional
* add ADA4610 operational amplifiers

* ada4610: integrate review feedback

* ADA4610-2xRM alias to NCS2325DM

* ADA4610-2xCP: correct pre-selected footprint

* ADA4610-2xCP: fix footprint filter
* add OPA569 high-current opamp in SO-20 PowerPAD

* fix some klc issues

* reduce x-size to get symmetry

* footprint

* fix footprint assignment and filter

* update name and fp-filter
The STM32L4x1 SoC do not have USB support and thus no VDDUSB pin.
A simple VDD pin is used instead. This probably comes from a copy and
paste issue from other another SoC in the family.
* added NCP662

* fixed grid

* recentered

* removed T1G suffix

* -removed asteriks from footprint filter
-changed pin names
-T1G suffix was already removed
* Add MAX941

* Improve MAX941 symbol

* MAX941: Pin 6 V-; keyword single comparator; splited into three atomic parts (SOIC, PDIP and MSOP package)

* MAX941: Package in description; MAX941xUA name and Fp filter
* Add MS5525DSO Pressure-Sensor

* Improve Pins

* Improve Pins - 2nd time

* Center pins on the right side
* Added BM78 Class 2 Bluetooth/BLE module

* BM78: Change pin length

* BM78SPPS5MC2: Change name

* BM78SPPS5MC2: set PMULDO_0 as passive pin

* BM78SPPS5MC2: change RST_N pin name to ~RST

* BM78SPPS5MC2: group P1xxx pins together

* BM78SPPS5MC2: Change pin 13 and pin 14 names

* BM78SPPS5MC2: Change ref and name location

* BM78SPPS5NC2: Add alias to BM78SPPS5MC2

* BM78SPPS5MC2: Set footprint

* BM78SPPS5MC2: Add footprint filter

* BM78SPPS5NC2: Reorder P1_X pins and change symbol width

* BM78SPPS5NC2: fix symbol center
* Add Nexperia PMEG SOT-1289 Schottky diode symbol (#2215)

* Add Nexperia PMEG SOT-1289 Schottky diode aliases (#2215)

* Fix FP
* add RJ45 LAN transformer Würth 74920111211
* 74980111211: fix datasheet URL & selected footprint
* Added PN512 RFID module

* pn512: Update description

* pn512: Update size, pins and name

* Set pin 14 TVSS invisible and passive

* Set EP visible
* add PN532_C1

* Switch order between I0/I1
Switch text order in P34
* Includes symbols for CPU ICs:
** 65C02
** 65C816
* Includes symbols for Interface ICs:
** 65C21
** 65C22
** 65C51
* Passes all tests from KLC helper scripts.
* Included recent additions to repository
* Lines sorted in lexicographically ascending order.
* 65C134
* 65C265
Passes all tests from KLC helper scripts.
* Change address pins (A##) from Tri-State to Output
* Stack power input pins (VDD and VSS)
* Change duplicate stacked power input pins to passive.
…bol name

* Switched all pins within CPU_WDC_6500.lib that were
  using graphic style "Inverted" to instead have a bar symbol
  over the name and a regular "Line" graphic style.
…bol name

* Switched all pins within MCU_WDC_6500.lib that were
  using graphic style "Inverted" to instead have a bar symbol
  over the name and a regular "Line" graphic style.
* Also switched remaining Tri-state pins to Bidirectional.
…bol name

* Switched all pins within Interface_WDC_6500.lib that were
  using graphic style "Inverted" to instead have a bar symbol
  over the name and a regular "Line" graphic style.
* Also switched remaining Tri-state pins to Bidirectional.
@ghost
Copy link

ghost commented Sep 23, 2020

Did you rebase this branch? Or why are there 129 commits?
Whatever you did, it is not optimal because:

  • TravisCI will now check all those commits and its output will be full of warnings/errors of unrelated parts
  • Looking at the diff in the github web-frontend also shows unrelated changes.

@McNeight
Copy link
Author

@cp-aquila Based on the suggestion from @myfreescalewebpage I did rebase against master to remove the changes I'd performed on sym-lib-table.

Since this pull request has a near zero chance of being merged into master before everything moves to GitLab anyway, I'm going to just close this pull request and recreate it at GitLab some other time.

-Neil

@McNeight McNeight closed this Sep 23, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Sep 23, 2020
@myfreescalewebpage
Copy link
Collaborator

ok @McNeight

@na-g
Copy link

na-g commented Sep 24, 2020

@McNeight, thanks for all the work you put into this. I wish it could have been merged. I hope that after the transition to GitLab, things can progress more quickly. With the Ben Eater videos, and such it seems that there is renewed interest, and this will be valuable to a number of hobbyists, myself included, and the 6502 community.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.