Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Create IGBT_Module library #2913

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Conversation

aris-kimi
Copy link
Collaborator

@aris-kimi aris-kimi commented Aug 14, 2020

Same with the footprint PR, second try for addition of IGBT_Module library, with some other symbols only from infineon (previous PR has only some from ST).
I would like to ask any reviewer to give priority to this one over the other.

Edit:
I have power stage connections exchangeable between symbols from previous/future (similar symbol) PRs.
I just saw letters instead of numbers for footprint pins. I wasn't aware of that. I custom-numbered them to avoid travis violation after KLC S4.1.3 Pin numbers must be unique (no two pins may have the same number)

I will act after guidance.

Addition:

FP50R06W2E3: https://www.infineon.com/dgdl/Infineon-FP50R06W2E3-DS-v02_02-EN.pdf?fileId=db3a30431b3e89eb011b455c99987d24

Aliases:

FP15R12W2T4: https://www.infineon.com/dgdl/Infineon-FP15R12W2T4-DS-v03_00-en_de.pdf?fileId=db3a30433ba77ced013bae67c3eb3a5e
FP25R12W2T4: https://www.infineon.com/dgdl/Infineon-FP25R12W2T4-DS-v02_02-EN.pdf?fileId=db3a3043163797a60116389cdaeb0183
FP25R12W2T4P: https://www.infineon.com/dgdl/Infineon-FP25R12W2T4P-DS-v03_00-EN.pdf?fileId=5546d4625bd71aa0015bfbc806e571fc
FP35R12W2T4: https://www.infineon.com/dgdl/Infineon-FP35R12W2T4-DS-v02_02-EN.pdf?fileId=db3a3043163797a6011638a0541501a0
FP35R12W2T4P: https://www.infineon.com/dgdl/Infineon-FP35R12W2T4P-DS-v03_00-EN.pdf?fileId=5546d4625bd71aa0015bfbbf0d7a71f8

Footprint PR: KiCad/kicad-footprints#2388

εικόνα

Red numbers is custom numbering for pin assignment:
εικόνα

infineon_fpxxx

Travis footprint violation:
Violating S5.1

For components with a single default footprint, footprint field is filled with valid footprint

filename

Specified footprint library does not exist

 - Footprint library 'IGBT_Module' was not found

Thank you for your time.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Aug 19, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Aug 25, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 25, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Aug 25, 2020

Hi @aris-kimi , thanks for contributing,

A few comments I have during my review:

  • No special character in the lib, please remove "TM" in the description
  • Reduce a bit the width of the symbol, it's currently very large

Do you have attributed the pin number yourself ? Maybe in this case something like BGA packages, with letter for the column and number for the line will be better, let see what the footprint experts say.

Cheers,
Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Aug 25, 2020
@aris-kimi
Copy link
Collaborator Author

#2773

I have it like this in order to be similar with the above. Power stages kept exchangable with each other. If you still need this to change inform me to start working.

@aris-kimi
Copy link
Collaborator Author

Just saw the edit @myfreescalewebpage , yes after travis violation that was the best i could thought off, but i liked your idea more. I will change this if footprint reviewer agrees.

Short question, do you might know if with new s-exp format those special characters will be allowed?

@chschlue
Copy link
Contributor

chschlue commented Aug 25, 2020

Actually, they're not explicitly forbidden in descriptions (see https://kicad-pcb.org/libraries/klc/G1.1/), but we try to limit them because the devs aren't overly confident in the current UTF-8 implementation.
We do have non-7bit-ASCII in descriptions if they're helpful (µ and Ω for example), but keywords are supposed to aid in searchability and hardly would anyone include ™ in search terms.

Edit: To answer the question, no, the new format isn't going to change anything directly.

@myfreescalewebpage
Copy link
Collaborator

@aris-kimi yes when you are a developer you are not always confident with special characters and I understand this :D If we accept this we will have plenty of Cyrillic, Spanish, Swedish, etc symbols and it's not really wanted.

@myfreescalewebpage
Copy link
Collaborator

Just need to wait the footprint now.

@aris-kimi
Copy link
Collaborator Author

@myfreescalewebpage , i have to share a thought since i just saw Transistor_IGBT libray with only one part. I think this library needs to be renamed to Transistor_IGBT_Module. What do you think?

@myfreescalewebpage
Copy link
Collaborator

To be honest with you I have think to the name of the library too, but "IGBT_Module" is not bad.
The last proposition you made is probably better, yes. You can change if you want.
You can ask the same question for the footprint and another reviewer will answer too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants