Added some TM* led and lcd driver symbols

[purdeaandrei]

• Add TM1620, TM1628, TM1629_LQFP44, TM1638, TM1640 LED driver symbols
• Add TM1621C, TM1621D, TM1621_LQFP44, TM1621_SSOP48 LCD driver symbols

---

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

• Provide a URL to a datasheet for the symbol(s) you are contributing
• Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
• Ensure that the associated footprints match the official footprint library
  • A new fitting footprint must be submitted if the library does not yet contain one.
• If there are matching footprint PRs, provide link(s) as appropriate
• Check the output of the Travis automated check scripts - fix any errors as required
• Give a reason behind any intentional library convention rule violation.

---

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

[CLAassistant]

All committers have signed the CLA.

[purdeaandrei]

[myfreescalewebpage]

Hi @purdeaandrei , thanks for contributing,

Partial review of TM1621C symbol below, I suggest you to apply the same modifications to the other symbols:

• Descriptions to be enhanced and package format not correct, you can indicate "Titan Micro Electronics 18x4 LCD Driver, SOP-28"
• Have you got a datasheet link in english ?
• Symbol is too much large
• Format of the footprint filter is not correct, should be SOIC*7.5x17.9mm*P1.27mm* for this device. Check the logic and apply to the other symbol please.
• Style of pin 7 should be "Line"

Cheers,
Joel

[purdeaandrei]

Hi Joel,

Thank you for your review,

Descriptions to be enhanced and package format not correct, you can indicate "Titan Micro Electronics 18x4 LCD Driver, SOP-28"

Okay, changes pushed

Have you got a datasheet link in english ?

Unfortunately I didn't find English datasheets for all of the symbols, but I did add English datasheets for the ones that I found.

Symbol is too much large

So what should I do about it? How large is too large?

Format of the footprint filter is not correct, should be SOIC7.5x17.9mmP1.27mm* for this device. Check the logic and apply to the other symbol please.

So I should not include the number of pins in the filter?

Style of pin 7 should be "Line"

Pin 7 (WR) is also used as a clock. I know this may have looked like a mistake, but I added it on purpose.
Is there a policy somewhere about what pins should be styled like clocks?
For instance should the CLK pin on some of the other symbols be styled as clock?
Should a pin named SCLK be styled as clock?

Thanks,
Andrei

[purdeaandrei]

@myfreescalewebpage ^

[myfreescalewebpage]

So what should I do about it? How large is too large?

Reduce of 100mil on the left and 100mil on the right for example.

So I should not include the number of pins in the filter?

Yes exactly

Is there a policy somewhere about what pins should be styled like clocks?

In the KiCad official library we use Line style for all pins. I don't know why, this is historically like that and it is now a recommendation to have consistency across the library.

Joel

[purdeaandrei]

@myfreescalewebpage

Reduce of 100mil on the left and 100mil on the right for example.

Aah, okay I understand now. I thought you were going to ask me to split it up into sub-symbols, which was an idea I would not have been a fan of.
I can certainly reduce the horizontal size of some of the symbols.
I have just reduced the horizontal size of the TM1621* symbols I am adding to the Driver_Display library.
I can't do the same to the ones I'm adding to the Driver_LED library, because reducing them would cause the right side pins to overlap with the power pins, and that would mean that I would have to move the power pins to the left, and not have them be centered. Is it okay to leave the symbols from Driver_LED as they are? Or would you prefer non-horizontally-centered power pins?

So I should not include the number of pins in the filter?

Yes exactly

Alright, was just double checking, changes pushed...

In the KiCad official library we use Line style for all pins. I don't know why, this is historically like that and it is now a recommendation to have consistency across the library.

Okay, understood, changes pushed.

[myfreescalewebpage]

Thanks, doing a full detailed review now:

TM1621C:

• Footprint should be Package_SO:SOP-28_7.5x17.9mm_P1.27mm (it does not exist you have to submit it)
• Fp filter SOP*7.5x17.9mm*P1.27mm*
• SEGx and COMx should be Tri-State
• Are you sure DATA is bidirectional ? It is possible to read register of the device ? I haven't seen that

TM1621D

• Footprint should be Package_SO:SOP-24_7.5x15.4mm_P1.27mm
• Fp filter SOP*7.5x15.4mm*P1.27mm*
• SEGx and COMx should be Tri-State
• Are you sure DATA is bidirectional ? It is possible to read register of the device ? I haven't seen that

TM1621_LQFP44

• The package in the description is just after a comma, not a dot: Titan Micro Electronics 32x4 LCD Driver, LQFP-44
• SEGx and COMx should be Tri-State
• BZ and BZ/ should be Output
• Are you sure DATA is bidirectional ? It is possible to read register of the device ? I haven't seen that

TM1621_SSOP48

• SEGx and COMx should be Tri-State
• BZ and BZ/ should be Output

TM1620

• Description: Titan Micro Electronics LED Driver with 8 seg x 6 grid / 10 seg x 4 grid, and 3-pin serial interface, SOP-20 is enough
• Footprint: Package_SO:SOP-20_7.5x12.8mm_P1.27mm
• Fp filter: SOP*7.5x12.8mm*P1.27mm*
• Name of pin 10 should be SEG13/GRID6 (main function near to the border) and type should be Bidirectional
• Name of pin 11 should be SEG14/GRID5 (main function near to the border) and type should be Bidirectional
• SEG pin should be Open Emitter and GRID pins should be Open Collector

TM1628

• Description: Titan Micro Electronics 13x4 or 10x7 LED Driver with key scanning support, SOP-28 is enough
• Footprint should be Package_SO:SOP-28_7.5x17.9mm_P1.27mm (it does not exist you have to submit it, same footprint already mentioned for TM1621C)
• Fp filter SOP*7.5x17.9mm*P1.27mm*
• NC pin should be on the border outline
• GRID5 should be above GRID6 and itself above GRID7
• GRID 1 to GRID4 should be above GRID5
• SEG pin should be Open Emitter and GRID pins should be Open Collector, "SEX/GIDx" should be Bidirectional
• K1 and K2 on the right is probably better to wire the buttons but it let you decide

TM1629_LQFP44

• Name should be "TM1629" (there isn't other package option, isn't it ?)
• NC pin should be on the border outline
• GRID1 should be above GRID2 and itself above GRID3 etc
• SEG pin should be Open Emitter and GRID pins should be Open Collector
• K1 to K4 on the right is probably better to wire the buttons but it let you decide

TM1638

• Description: Titan Micro Electronics LED Driver with 10 seg x 8 grid, 8x3bit key scan, and 3-pin serial interface, SOP-28 is enough
• Footprint should be Package_SO:SOP-28_7.5x17.9mm_P1.27mm (it does not exist you have to submit it, same footprint already mentioned for TM1621C)
• Fp filter SOP*7.5x17.9mm*P1.27mm*
• SEG pin should be Open Emitter and GRID pins should be Open Collector
• K1 to K3 on the right is probably better to wire the buttons but it let you decide

TM1640

• Description: Titan Micro Electronics LED Driver with 8 sections x 16 bits, and dual-line serial interface, SOP-28 is enough
• Footprint should be Package_SO:SOP-28_7.5x17.9mm_P1.27mm (it does not exist you have to submit it, same footprint already mentioned for TM1621C)
• Fp filter SOP*7.5x17.9mm*P1.27mm*
• SEG pin should be Open Emitter and GRID pins should be Open Collector

Joel

[myfreescalewebpage]

@purdeaandrei ping

[myfreescalewebpage]

@purdeaandrei ping

[myfreescalewebpage]

No news of the author, indicate this is Abandoned