Added DE152 from DE122

[valerionew]

Footprint PR: KiCad/kicad-footprints#2423

Datasheet: https://www.tme.eu/Document/a8ad3d6d1be7f7b544cda7e86ae7bac8/DE152.pdf

⚠️ Deprecation warning

In preparation for the KiCad v6 release this repository will be locked down on Sept 1, 2020. No new pull requests will be accepted. Existing pull requests can be worked on until Oct 1, 2020. Changes breaking v5.1 compatibility can be merged starting Sept 1, 2020.

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).

We plan to convert the library to the new v6 S-expr format after it is imported to GitLab. That also means that old pull requests will need to be redone with the v6 format if they are not merged before then.

---

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

• Provide a URL to a datasheet for the symbol(s) you are contributing
• Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
• Ensure that the associated footprints match the official footprint library
  • A new fitting footprint must be submitted if the library does not yet contain one.
• If there are matching footprint PRs, provide link(s) as appropriate
• Check the output of the Travis automated check scripts - fix any errors as required
• Give a reason behind any intentional library convention rule violation.

---

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

[myfreescalewebpage]

Hi @valerionew , thanks for contributing,

A few comments I have during my review:

• Do you have a datasheet link on the manufacturer web site as done for DE122 ?
• Symbol is not centered (see travis error)
• Symbol outline should be 10mil
• Both BP pin should be Input to respect stacking in this configuration
• NC pins to be moved on the border outline of the symbol

Else just need to wait the footprint (please provide link to the PR when available - Important note: try to do it befoe the 2020-09-01 because the repository will be locked in preparation of the KiCad V6 and we will not accept new PR)

Cheers,
Joel

[valerionew]

• Do you have a datasheet link on the manufacturer web site as done for DE122 ?
• Symbol is not centered (see travis error)
• Symbol outline should be 10mil
• Both BP pin should be Input to respect stacking in this configuration
• NC pins to be moved on the border outline of the symbol

Hey Joel, sorry for those rookie mistakes, i haven't made a contribution in a while! Should be all fixed now, footprint PR is here:
KiCad/kicad-footprints#2423

[myfreescalewebpage]

Thanks for the update. Most points are fine, except NC pins: why remove them ? They should be on the symbol on the border outline. Example:

[valerionew]

I removed them following KLC S4.5
They were a lot, making the symbol excessively big, and serving no purpose at all.

Pins not connected on the footprint may be omitted from the symbol
[...] in some cases unconnected pins may be omitted from the schematic symbol.

Pins may only be omitted if they are never to be connected under any circumstances

Unconnected pins may only be omitted if including them would make the symbol unnecessarily large.

[myfreescalewebpage]

Here they are not so much NC pins. We are speaking of dozen of NC pins in the KLC, but the device with such kind of situation are very rare.

[valerionew]

Would it be appropriate to put them back?

[myfreescalewebpage]

Yes please. It's always preferable to have them.

[valerionew]

There we go, fixed :)

[valerionew]

Also fixed in #2936

[myfreescalewebpage]

Thanks, just need to wait the footprint.

[valerionew]

Probably will take some time, i've had PRs open as long as since November 😄

[myfreescalewebpage]

Yes I know it's hard work, especially for the footprint (I'm not confident when I do it, I let other people making the footprint reviews)!

[myfreescalewebpage]

No news of the author, indicate this is Abandoned