Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ARP filtering #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raja-grewal
Copy link
Contributor

As per #279 (comment).

Changes

Set sysctl net.ipv4.conf.*.arp_filter=1

Mandatory Checklist

  • Legal agreements accepted. By contributing to this organisation, you acknowledge you have read, understood, and agree to be bound by these these agreements:

Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint

Optional Checklist

The following items are optional but might be requested in certain cases.

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@ArrayBolt3
Copy link
Contributor

I may just be getting confused by the legitimately difficult-to-understand documentation for arp_ignore in Linux, but I don't see anything this option does that arp_ignore=2 doesn't already do. Personally though, I'm fine with enabling it though as a form of defense-in-depth (if a bug in Linux causes one option to just not work, the other one may be able to keep the system from becoming vulnerable anyway).

I do worry about how this and arp_ignore=2 may affect bridged networking under VirtualBox and libvirt. Won't these options prevent the VM from being able to find the IP addresses of any other device on the local network? If so, it may still be worth it to break that, but only if we document how to unbreak it and support doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants