Skip to content

Fix link / learn/getting started/connect wallet to explorer app.md - #72

Merged
4 commits merged into
KiiChain:mainfrom
raddenpattah:fix-link-/-learn/getting-started/connect-wallet-to-explorer-app.md
Sep 17, 2025
Merged

Fix link / learn/getting started/connect wallet to explorer app.md#72
4 commits merged into
KiiChain:mainfrom
raddenpattah:fix-link-/-learn/getting-started/connect-wallet-to-explorer-app.md

Conversation

@raddenpattah

@raddenpattah raddenpattah commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Description

there's double link in "set up a wallet" link, causing double link but its a different link and causing typo in the link

Type of change

Please delete options that are not relevant.

  • Documentation (updates documentation on the project)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

After a sentence ends, a period must be added, but there the period is too far away
Repeating the same sentence twice within a single paragraph sounds a bit odd, so it should be revised by adding a comma and the conjunction “and.” This change makes the wording flow much better and eliminates the awkwardness.

As for the phrase “manage their 24 set word keys,” it is uncommon and somewhat confusing. In the crypto ecosystem it is normally referred to as a **24‑word seed phrase** or a **24‑word recovery phrase**.
there's double link in "set up a wallet" link, causing double link but its a different link and causing typo
@coderabbitai

coderabbitai Bot commented Sep 17, 2025

Copy link
Copy Markdown

Walkthrough

  • learn/getting-started/README.md: Fixed punctuation in the “Get a wallet in Testnet” section (removed stray space before period after “Keplr”).
  • learn/getting-started/connect-wallet-to-explorer-app.md: Corrected a malformed Markdown link by removing an extraneous “[t]”, resulting in a single proper link to “Set Up a Web Wallet”.
  • learn/getting-started/download-a-mobile-wallet.md: Merged two sentences into one for the mobile wallet availability statement and updated terminology from “24 set word keys” to “24-word seed phrase”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title explicitly indicates the intent—fixing a link in the "connect wallet to explorer app" document—so it matches the main change described in the raw summary and PR objectives; however, it includes the full file path and filename with slashes which is noisy and less concise than recommended for PR titles. Because it accurately reflects the change it meets the pass criteria. The title could be clearer but is not misleading.
Description Check ✅ Passed The PR description clearly states the issue (a duplicated/typoed "Set Up a Web Wallet" link), identifies the change as documentation, and aligns with the raw summary and PR objectives, so it is related to the changeset and satisfies the lenient description check. The description is specific enough to pass. The unchecked test checklist items do not make the description off-topic.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)
learn/getting-started/README.md (2)

34-35: Fix EVM address prefix (O vs 0).
The example shows “Ox...” (letter O). It must be “0x...” (zero).

-$request Ox12345abcde…
+$request 0x12345abcde…

95-95: Fix broken link in learn/getting-started/README.md

learn/getting-started/README.md:95 — replace the placeholder link target broken-reference with ../../validate-the-network/run-a-validator-full-node/README.md (points to "Run a Validator / Full Node").

learn/getting-started/connect-wallet-to-explorer-app.md (1)

15-15: Link text/URL mismatch (Explorer vs App).
Anchor text shows explorer.kiichain.io but the href points to app.kiiglobal.io — pick one canonical destination and make both match.
File: learn/getting-started/connect-wallet-to-explorer-app.md (line 15)

-Go to [https://explorer.kiichain.io](https://app.kiiglobal.io/) ...
+Go to [https://explorer.kiichain.io](https://explorer.kiichain.io) ...
# or
+Go to [https://app.kiiglobal.io](https://app.kiiglobal.io) ...
🧹 Nitpick comments (5)
learn/getting-started/README.md (2)

17-17: Hyphenation and style nits in wallet sentence.

  • Use “Cosmos‑based”.
  • Optional: keep list punctuation consistent (use Oxford comma or not across docs).
-Testnet Oro supports wallet connections with EVM and Cosmos based wallets like MetaMask and Keplr. To set up a wallet, make sure you have the MetaMask or Keplr wallet extension downloaded in your web browser. MetaMask supports extension downloads for the following web browsers: Chrome, Firefox, Brave, Edge and Opera. Keplr supports wallets in Chrome, Firefox and Edge.
+Testnet Oro supports wallet connections with EVM and Cosmos‑based wallets like MetaMask and Keplr. To set up a wallet, make sure you have the MetaMask or Keplr wallet extension downloaded in your browser. MetaMask supports extension downloads for the following browsers: Chrome, Firefox, Brave, Edge, and Opera. Keplr supports Chrome, Firefox, and Edge.

23-23: Grammar nit: compound modifier.
Use “24‑hour period.”

-... receive 2,500 tokens within a 24 hour period.
+... receive 2,500 tokens within a 24‑hour period.
learn/getting-started/connect-wallet-to-explorer-app.md (1)

9-9: Brand/style nits.

  • “Metamask.io” → “metamask.io”; brand “MetaMask”.
  • “web extension browser” → “browser extension”.
-Go to Metamask.io and download and install the web extension browser.
+Go to metamask.io and download and install the browser extension.
learn/getting-started/download-a-mobile-wallet.md (2)

10-10: Verb form and minor style.
Use “log in” (verb) instead of “login” (noun).

-... users can login via email or manage their 24‑word seed phrase.
+... users can log in via email or manage their 24‑word seed phrase.

12-14: Brand term: “App Store”, not “Apple Store”.

-Apple Store: [https://apps.apple.com/us/app/kii-mobile/id6474740411](https://apps.apple.com/us/app/kii-mobile/id6474740411)
+App Store: [https://apps.apple.com/us/app/kii-mobile/id6474740411](https://apps.apple.com/us/app/kii-mobile/id6474740411)
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a938e51 and 5021920.

📒 Files selected for processing (3)
  • learn/getting-started/README.md (1 hunks)
  • learn/getting-started/connect-wallet-to-explorer-app.md (1 hunks)
  • learn/getting-started/download-a-mobile-wallet.md (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Request and Push
learn/getting-started/README.md

[error] 1-1: Spelling check failed. Misspelled words detected: onchain, payins, rebalance, AML, RWAs.


[error] 1-1: Spelling check failed. Misspelled words detected: RWAs.

🔇 Additional comments (2)
learn/getting-started/README.md (1)

1-1: Address CI spelling failures.
Pipeline flags: onchain, payins, rebalance, AML, RWAs. Either fix to “on‑chain”, “pay‑ins”, etc., or add project dictionary exceptions.

Consider adding to cspell/codespell config:

+// cspell.json
+{
+  "words": ["onchain","payins","rebalance","AML","RWAs"]
+}
learn/getting-started/connect-wallet-to-explorer-app.md (1)

19-19: LGTM: malformed link fixed.
The “Set Up a Web Wallet” link now resolves correctly.

@jhelison jhelison closed this pull request by merging all changes into KiiChain:main in 6ec55c6 Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants