Skip to content

Comments

Use tokio UnixStream / NamedPipeClient API instead of parity-tokio-ipc#52

Merged
KillTheMule merged 1 commit intoKillTheMule:masterfrom
sdroege:no-parity-tokio-ipc
Mar 1, 2025
Merged

Use tokio UnixStream / NamedPipeClient API instead of parity-tokio-ipc#52
KillTheMule merged 1 commit intoKillTheMule:masterfrom
sdroege:no-parity-tokio-ipc

Conversation

@sdroege
Copy link
Contributor

@sdroege sdroege commented Mar 1, 2025

Fixes #49

Licensing: The code contributed to nvim-rs is licensed under the MIT or
Apache license as given in the project root directory.

@KillTheMule
Copy link
Owner

KillTheMule commented Mar 1, 2025

Hey, thanks for that! We can let CI handle the windows part, no biggie. The current failures seem unrelated to this PR, I'd see if I can fix this on master and then you can rebase. Might leave some comments, but first lets get CI running properly :)

@sdroege
Copy link
Contributor Author

sdroege commented Mar 1, 2025

Thanks, Windows is passing fine now. Linux/macOS CI failures are indeed unrelated, as you say. Let me know when to rebase :) Thanks for looking into that!

@sdroege
Copy link
Contributor Author

sdroege commented Mar 1, 2025

Also for Linux, I'm using this with nvim-gtk so it should be working fine.

@KillTheMule
Copy link
Owner

Ok, if you could put in those links I'd be grateful, afterwards (after rebasing to master) CI should be green. Thanks again!

@sdroege sdroege force-pushed the no-parity-tokio-ipc branch from be52bb3 to 0c8de41 Compare March 1, 2025 11:47
@sdroege
Copy link
Contributor Author

sdroege commented Mar 1, 2025

Should be OK now

@KillTheMule KillTheMule merged commit 6ddb8a0 into KillTheMule:master Mar 1, 2025
5 checks passed
@sdroege sdroege deleted the no-parity-tokio-ipc branch March 1, 2025 12:24
@sdroege
Copy link
Contributor Author

sdroege commented Mar 1, 2025

If you can make a 0.7.1 release with this change that would probably make some people happy :)

@KillTheMule
Copy link
Owner

I will be going with 0.8 since I also updated the neovim API (and dependencies).

@KillTheMule
Copy link
Owner

It's 0.9 now because cargo publish is confusing for me :( Still, I don't see myself yanking this just because I skipped 0.8, so I guess we'll roll with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency tokio-parity-ipc

2 participants