Skip to content

Conversation

@beatlevic
Copy link
Contributor

@beatlevic beatlevic commented Nov 10, 2025

Remove obsolete context tracking and cleaning up types.

  • Simplifies getFromLLM() method:
    The method extracts prefix, suffix, and languageId from the context, but these could be passed directly since they're already available in the caller.

  • Reduces duplication in contextToAutocompleteInput():
    The function extracts prefix/suffix which is already done in the caller.

  • Simplifies context building:
    Since we're building the context in provideInlineCompletionItems and immediately converting it to AutocompleteInput,

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2025

⚠️ No Changeset found

Latest commit: 9449534

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@markijbema markijbema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either AutocompleteInput needs to be the input to the inline completion provider, or we should just ignore the type; the whole goal of using it as input is that we have better compatibility with the continue inline completion provider.

Currently we don't use that as we use continue from a higher level, however, we might still want to move towards this way as we don't have continue tied into the rest of our system, and this might hinder that

Copy link
Contributor

@markijbema markijbema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive added some suggestions for further cleanup, but they're also slightly out of scope, so fine with merging as is and doing that separately

@beatlevic beatlevic enabled auto-merge November 11, 2025 12:39
@beatlevic beatlevic merged commit 5019276 into main Nov 11, 2025
12 checks passed
@beatlevic beatlevic deleted the beatlevic/cleanup-classic-autocomplete-context branch November 11, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants