-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add AWS Bedrock API Key support to docs #4755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| 1. **AWS Access Keys (Recommended for Development):** | ||
| 1. **Bedrock API Key:** | ||
| - Create a Bedrock-specific API key in the AWS Console. This is a simple service-specific authentication method. | ||
| - See the [AWS documentation on Bedrock credentials](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_bedrock.html) for instructions on creating an API key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 CRITICAL: Invalid AWS documentation link and non-existent feature
This documentation describes a "Bedrock API Key" authentication method that does not exist in AWS Bedrock. AWS Bedrock uses standard AWS authentication methods (IAM credentials, profiles, or roles) - there is no service-specific API key.
The linked URL (https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_bedrock.html) does not exist in AWS documentation.
Additionally, I found no corresponding code in the Kilo Code codebase to support a "Bedrock API Key" authentication method.
Please verify this feature exists before documenting it, or remove this section if it was added in error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It exists and works, and that link does indeed work.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR updates the AWS Bedrock provider documentation to add a third authentication option: "Bedrock API Key". The changes include:
The documentation changes are well-structured and consistent with the existing format. Files Reviewed (1 file)
|
Add connection path sentence.
Adds simple initial docs for AWS Bedrock support.