Show toast notification when skills are added or removed #4888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5b245a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a notification system to alert users when skills are added or removed from their project. The implementation includes a generic ConfigContextManager for tracking configuration changes, integration with the existing SkillsManager, new type definitions for configuration changes, and Storybook stories for the UI component.
Key changes:
- New generic configuration change tracking system that can work with any config type (skills, workflows, commands, rules, MCP servers)
- Integration with SkillsManager to detect and notify on skill changes
- Type definitions moved to shared packages for reusability
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
packages/types/src/context-config.ts |
Defines types for configuration changes (ContextConfigType, ContextConfigChange) |
packages/types/src/index.ts |
Exports new context-config types |
src/shared/context-config.ts |
Re-exports types from @roo-code/types for backward compatibility |
src/services/config/ConfigContextManager.ts |
Implements generic configuration change tracking and notification logic |
src/services/skills/SkillsManager.ts |
Integrates ConfigContextManager to track skill changes and watch file system |
src/services/skills/SkillsManager.spec.ts |
Tests for configuration change detection logic |
apps/storybook/stories/ConfigDiscoveryToast.stories.tsx |
Storybook stories for the toast notification UI component |
hassoncs
force-pushed
the
skills-discovery
branch
4 times, most recently
from
53a2e83 to
a6d14ac
Compare
Introduces a ConfigChangeNotifier service that tracks configuration changes and displays VSCode notifications when skills are added or removed from global or project configurations. Includes i18n support for 25 languages and type definitions for context configuration changes.
hassoncs
force-pushed
the
skills-discovery
branch
from
a6d14ac to
5b245a2
Compare
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR adds a notification system for skill configuration changes. The implementation is clean and well-structured:
Notable implementation details:
Files Reviewed (22 files)
|
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR adds a well-structured notification system for skill configuration changes. The implementation:
The file watcher pattern change from Files Reviewed (24 files)
|
chrarnoldus
approved these changes
Jan 9, 2026
This was referenced Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect when global or local configuration things change for skills, workflows, and rules and show a VS Code notification
At some point we want to move the notification into our own panel, but this was just the MVP to let users know when we do detect skills changes