Skip to content

Conversation

@kevinvandijk
Copy link
Collaborator

This was double rendered in settings

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2026

🦋 Changeset detected

Latest commit: 20f1a16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
kilo-code Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kiloconnect
Copy link
Contributor

kiloconnect bot commented Jan 9, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

This PR correctly removes a duplicate MCP section rendering in the SettingsView component. The <McpView /> component was being rendered twice when activeTab === "mcp" - once at line 1163 and once at the removed location (previously around lines 1215-1218). The fix properly eliminates this duplication.

Other Observations (not in diff)

While reviewing the file, I noticed a potential issue in unchanged code that cannot receive an inline comment:

File Line Issue
webview-ui/src/components/settings/SettingsView.tsx 115, 120 The sectionNames array contains "mcp" twice (lines 115 and 120). This may cause unexpected behavior with TypeScript type inference or array operations. Consider removing the duplicate entry.
Files Reviewed (2 files)
  • .changeset/purple-pears-visit.md - Properly formatted changeset
  • webview-ui/src/components/settings/SettingsView.tsx - Duplicate MCP section removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants