fix: agent manager session disappears due to gitUrl race condition #4892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Agent Manager sessions disappearing immediately after starting
Fixes an issue where Agent Manager sessions would disappear immediately after starting, particularly when there's already a session running in the right sidebar.
Root Cause
A race condition in
currentGitUrlinitialization caused Agent Manager sessions to be filtered out immediately after creation:AgentManagerProviderconstructor,initializeCurrentGitUrl()is called asynchronously but not awaitedcurrentGitUrlstarts asundefinedstartAgentSession()is called, it fetchesgitUrlfrom the workspace and creates the session with thisgitUrlpostStateToWebview()is called, which usesgetFilteredState()withthis.currentGitUrlcurrentGitUrlis stillundefined(becauseinitializeCurrentGitUrl()hasn't completed), but the session has agitUrl, the session is filtered out bygetSessionsForGitUrl()Fix
Modified
startAgentSession()to updatecurrentGitUrlwhen fetching the git URL for a new session, ensuring the filter matches the session'sgitUrl: