Skip to content

Conversation

@marius-kilocode
Copy link
Collaborator

Removes an unnecessary TODO comment that said "This might be redundant" without providing actionable information. The code simply stores a decoration reference, which is a standard pattern.

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2026

⚠️ No Changeset found

Latest commit: 72ca86b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kiloconnect
Copy link
Contributor

kiloconnect bot commented Jan 9, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The change correctly removes a speculative TODO comment that was questioning whether the this.currentDecoration = decoration assignment might be redundant. Upon review, this assignment is not redundant - it's essential for:

  • Using currentDecoration later in the same method (lines 777, 785)
  • Clearing decorations in hideAllNextEditWindows()
  • Proper cleanup in dispose()

Removing the misleading TODO comment is appropriate.

Files Reviewed (1 file)
  • src/services/continuedev/core/vscode-test-harness/src/activation/NextEditWindowManager.ts - 0 issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants